-
-
Notifications
You must be signed in to change notification settings - Fork 300
fix - Implement tabs instead of stacked views #16241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nopbody on file. |
|
@nopbody is attempting to deploy a commit to the Unlock Protocol Team on Vercel. A member of the Team first needs to authorize it. |
|
ready for review |
|
This is looking very good! |
|
Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nopbody on file. |
|
Please add yourself to the CLA file in another PR so we can run everything! |
Done - #16243 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the /my-events page to use a tabbed interface instead of stacked disclosure sections, improving the user experience by allowing users to switch between viewing their events and event collections.
Key Changes:
- Replaced Disclosure components with Tab components from @headlessui/react
- Introduced tab state management with useState hook
- Simplified the UI by removing accordion-style expand/collapse functionality
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| unlock-app/src/components/content/event/MyEventsContent.tsx | Converted two Disclosure sections into a Tab.Group with two tabs for events and collections |
| .clabot | Added new contributor "nopbody" to the CLA signatory list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
087e008 to
ac788f3
Compare
|
ready for review |
Description
modified
/my-eventspage to use tabs instead of stacked viewsIssues
Fixes #16188
Checklist:
Screen.Recording.2025-10-16.at.02.59.54.mov