Skip to content

Conversation

@nopbody
Copy link
Contributor

@nopbody nopbody commented Oct 15, 2025

Description

modified /my-events page to use tabs instead of stacked views

Issues

Fixes #16188

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Screen.Recording.2025-10-16.at.02.59.54.mov

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2025

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nopbody on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@vercel
Copy link

vercel bot commented Oct 15, 2025

@nopbody is attempting to deploy a commit to the Unlock Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@nopbody
Copy link
Contributor Author

nopbody commented Oct 15, 2025

ready for review

@julien51
Copy link
Member

This is looking very good!

@cla-bot
Copy link

cla-bot bot commented Oct 27, 2025

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @nopbody on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@julien51
Copy link
Member

Please add yourself to the CLA file in another PR so we can run everything!

@nopbody
Copy link
Contributor Author

nopbody commented Oct 27, 2025

Please add yourself to the CLA file in another PR so we can run everything!

Done - #16243

@julien51 julien51 requested review from 0xTxbi, Copilot and julien51 and removed request for Copilot October 28, 2025 00:40
@cla-bot cla-bot bot added the cla-signed label Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the /my-events page to use a tabbed interface instead of stacked disclosure sections, improving the user experience by allowing users to switch between viewing their events and event collections.

Key Changes:

  • Replaced Disclosure components with Tab components from @headlessui/react
  • Introduced tab state management with useState hook
  • Simplified the UI by removing accordion-style expand/collapse functionality

Reviewed Changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

File Description
unlock-app/src/components/content/event/MyEventsContent.tsx Converted two Disclosure sections into a Tab.Group with two tabs for events and collections
.clabot Added new contributor "nopbody" to the CLA signatory list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nopbody
Copy link
Contributor Author

nopbody commented Oct 28, 2025

ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tabs instead of "stacked" views.

2 participants