Skip to content

Conversation

@kricsleo
Copy link
Member

resolves #522
(resolves #521)

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1@47fe807). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v1     #524   +/-   ##
=====================================
  Coverage      ?   82.92%           
=====================================
  Files         ?        5           
  Lines         ?      246           
  Branches      ?      122           
=====================================
  Hits          ?      204           
  Misses        ?       34           
  Partials      ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pi0 pi0 changed the title fix: ensure headers is an instance of Headers fix: normalize options.headers (again) after onRequest hook Nov 1, 2025
@pi0 pi0 merged commit 1a4ce48 into unjs:v1 Nov 1, 2025
6 checks passed
@danielroe
Copy link
Member

@pi0 could we do this at the type level instead? ie disallowing assigning to headers?

@pi0
Copy link
Member

pi0 commented Nov 1, 2025

@danielroe good idea! I think hooks should accept resolved config type not input. Feel free to drop a PR ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants