GitHub Actions: install [email protected] explicitly for running test cases on MacOS #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2803 +/- ##
=======================================
Coverage 86.96% 86.96%
=======================================
Files 193 193
Lines 44000 44000
=======================================
Hits 38263 38263
Misses 5737 5737 Continue to review full report at Codecov.
|
masatake
force-pushed
the
github-actions-fix-package-installation
branch
from
531a854 to
f4d1a7e
Compare
…libxml2 fails Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
github-actions-fix-package-installation
branch
from
f4d1a7e to
b3661ed
Compare
|
I don't understand why this is needed. However, failing to setup a test environment on MacOS is so critical for our development. |
leleliu008
reviewed
Jan 16, 2021
Comment on lines
+30
to
+33
| # libxml2 requires [email protected]. | ||
| # However, the request is not satisfied with just installing libxml2. | ||
| brew install libxml2 || brew link --overwrite [email protected] | ||
| brew install autoconf automake pkg-config jansson libyaml bash gdb docutils |
There was a problem hiding this comment.
GitHub Actions VM macOS10.15 macOS11.0 have pre-installed [email protected] via HomeBrew, the error happens when [email protected] can be upgraded, so we should upgrade [email protected] first.
brew upgrade [email protected] || brew link --overwrite [email protected]
brew install libxml2 jansson libyaml autoconf automake pkg-config bash gdb docutils
There was a problem hiding this comment.
Thank you. You know so many things! I will make a pull request reflecting this suggestion.
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Jan 16, 2021
…teps Quoted from @leleliu008's comment in universal-ctags#2803: GitHub Actions VM macOS10.15 macOS11.0 have pre-installed [email protected] via HomeBrew, the error happens when [email protected] can be upgraded, so we should upgrade [email protected] first. Signed-off-by: Masatake YAMATO <[email protected]>
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Jan 16, 2021
…teps Quoted from @leleliu008's comment in universal-ctags#2803: GitHub Actions VM macOS10.15 macOS11.0 have pre-installed [email protected] via HomeBrew, the error happens when [email protected] can be upgraded, so we should upgrade [email protected] first. Signed-off-by: Masatake YAMATO <[email protected]>
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Jan 16, 2021
…teps Quoted from @leleliu008's comment in universal-ctags#2803: GitHub Actions VM macOS10.15 macOS11.0 have pre-installed [email protected] via HomeBrew, the error happens when [email protected] can be upgraded, so we should upgrade [email protected] first.
masatake
added a commit
that referenced
this pull request
Jan 16, 2021
…teps Quoted from @leleliu008's comment in #2803: GitHub Actions VM macOS10.15 macOS11.0 have pre-installed [email protected] via HomeBrew, the error happens when [email protected] can be upgraded, so we should upgrade [email protected] first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masatake YAMATO [email protected]