Skip to content

Conversation

@ShootingStarD
Copy link

Solves issue : #1994 + add the missing description and title fields that were not loaded previously.

I also had to modify a bit the tests, maybe due to the new specs of frictionless

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (812b2a8) to head (6954e01).
⚠️ Report is 360 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
- Coverage   94.28%   93.67%   -0.61%     
==========================================
  Files          91      121      +30     
  Lines        7013     9617    +2604     
==========================================
+ Hits         6612     9009    +2397     
- Misses        401      608     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tool.setuptools_scm]
version_file = "pandera/_version.py"

[project]
Copy link
Collaborator

@cosmicBboy cosmicBboy May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert formatting changes to this file, it's not relevant to the PR. Will also need to document that pandera only supports frictionless >= 5.18.1 after these changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, sorry my vscode used ruff as autoformater

@ShootingStarD
Copy link
Author

@cosmicBboy I do not understand the failing linters error, what are the problems?

@Jarek-Rolski
Copy link
Contributor

@ShootingStarD You need to update frictionless version in one more place link

@cosmicBboy
Copy link
Collaborator

no problem @ShootingStarD will take a look after cutting the 0.24.0 release (by eow)

@Jarek-Rolski
Copy link
Contributor

@ShootingStarD According to errors, you still need to update the frictionless version in environment.yml and recreate requirements file with python scripts/generate_pip_deps_from_conda.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants