-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix: resolve loading problem of frictionless + add the missing descri… #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ption and title fields
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
- Coverage 94.28% 93.67% -0.61%
==========================================
Files 91 121 +30
Lines 7013 9617 +2604
==========================================
+ Hits 6612 9009 +2397
- Misses 401 608 +207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [tool.setuptools_scm] | ||
| version_file = "pandera/_version.py" | ||
|
|
||
| [project] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert formatting changes to this file, it's not relevant to the PR. Will also need to document that pandera only supports frictionless >= 5.18.1 after these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, sorry my vscode used ruff as autoformater
|
@cosmicBboy I do not understand the failing linters error, what are the problems? |
|
@ShootingStarD You need to update frictionless version in one more place link |
|
no problem @ShootingStarD will take a look after cutting the 0.24.0 release (by eow) |
|
@ShootingStarD According to errors, you still need to update the |
Solves issue : #1994 + add the missing description and title fields that were not loaded previously.
I also had to modify a bit the tests, maybe due to the new specs of frictionless