Add CLDR calendar codes to ICU4X calendar docs #7082
Conversation
| /// The kind of an [`HijriSimulated`], Mecca calendar | ||
| /// | ||
| /// This corresponds to the `"islamic-rgsa"` [CLDR calendar](https://unicode.org/reports/tr35/#UnicodeCalendarIdentifier). | ||
| HijriSimulatedMecca, |
There was a problem hiding this comment.
Observation: we have islamic-rgsa in AnyCalendarKind? (I know we discuss this at great length but I'm still surprised to see it here)
There was a problem hiding this comment.
Yeah, it's not used by Temporal but it's there. Probably wouldn't have it if we didn't.
I recently tweaked temporal_rs so that it will discard rgsa inputs.
Co-authored-by: Shane F. Carr <[email protected]>
Co-authored-by: Shane F. Carr <[email protected]>
| /// This calendar is identical to the [`Gregorian`](super::Gregorian) calendar, | ||
| /// except that it uses a single `default` era instead of `bce` and `ce`. | ||
| /// | ||
| /// This corresponds to the `"iso8601"` [CLDR calendar](https://unicode.org/reports/tr35/#UnicodeCalendarIdentifier). |
There was a problem hiding this comment.
issue: I'm not sure about this. while we currently resolve the CalendarAlgorithm::Iso8601 to AnyCalendar::Iso, I don't think that's quite the same on the CLDR level. -u-ca-iso8601 is meant to be a Gregorian format that uses YMD ordering in the skeletons.
There was a problem hiding this comment.
Yeah, I was unsure of that part. Can remove this snippet.
Temporal considers this to mean a generally useful ISO calendar.
| pub enum AnyCalendarKind { | ||
| /// The kind of a [`Buddhist`] calendar | ||
| /// | ||
| /// This corresponds to the `"buddhist"` [CLDR calendar](https://unicode.org/reports/tr35/#UnicodeCalendarIdentifier). |
There was a problem hiding this comment.
these should link to the CalendarAlgorithm variant, which already links to the LDML
There was a problem hiding this comment.
https://unicode-org.github.io/icu4x/rustdoc/icu/calendar/preferences/enum.CalendarAlgorithm.html
Yeah but the exact correspondence isn't documented there either.
Happy to add docs there too but I don't actually think we should cross reference here: I've been annoyed at the number of clicks it takes to figure this out each time and it's fine to be repetitive in docs.
3 participants
Fixes #7038
I didn't add things to
locale_corebut we could do that there too.