Skip to content

Fix css for login page has external login #19843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NguyenThuyLan
Copy link
Contributor

This PR fixes for the issue #19628

@AndyButland
Copy link
Contributor

I'm still seeing a border on the screen when you have external login's configured @NguyenThuyLan:

image

It's a bit weird, as it's not always there. If I inspect the element it disapears but if I click back on the screen it comes back. So I don't think it's caching. I don't see this once I click to "Sign in with Umbraco".

@iOvergaard
Copy link
Contributor

The border is coming from the native <dialog /> element in the browser, I believe (MDN seems to confirm this). The screen with external login is technically a modal/dialog. You would probably need to interact directly with that element, and that may be hidden inside the <uui-popover-container /> element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants