Save all edit events internally #445
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves replacement/edit events in two places:
RoomInfo::messagewith a new message type.This is needed for read receipts on edits and redaction of edits to work.
Message::eventforMessageEvent::OriginalandMessageEvent::Local(though I'm not sure whether a local event could get edited).This allows every access to the message body to be replaced by an access to the newest edit.
If an edit is redacted, it is simply removed from this list.
In case the edit event is loaded before the message itself, it is saved to
RoomInfo::unloaded_edits.possible future additions
msg_not_hiddeninsrc/windows/room/scrollback.rsis used to hide the edit events from the timeline and could be extended to hide other kinds of events.:edits, making it possible to view and redact edit events.fixes #431