Allow notifications on open room if terminal not focused #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t relates to is open. Application::focused state is now available in the store.
|
Looks great, thank you! |
benjajaja
reviewed
May 21, 2024
benjajaja
approved these changes
May 25, 2024
|
@Andrew-Collins This is a great addition, thank you! 🙏 And I believe that @benjajaja is correct that we don't get the focused state on startup, but only whenever the window changes. (And that doesn't always happen with every terminal either). Defaulting |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is to implement #276.
It does this by putting the
focusedstate of the application into the store and then checks it in the notifications handler.This results in notifications being muted only if the room is currently displayed and the terminal is in focus.
If you would like a config entry to control this just let me know. :)