Display file sizes for attachments #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested for now. May not work if `size` is not present in message content info. Signed-off-by: Oror <[email protected]>
Signed-off-by: Oror <[email protected]>
Now using a `macro_rule!` to avoid code repetition. Signed-off-by: Oror <[email protected]>
|
This looks great! Thank you for adding more tests, too! 🙏 |
ulyssa
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first PR to take a look at the code base of this project (and a bit more at matrix internals).
It displays the attachment file size by appending it in the displayed messages.
For example, it would show
[Attached Image: Alt Text (12.34 kB)]or[Attached Image: Alt Text]if thesizefield is not present in the message information.Adds the
humansizecrate toCargo.toml.Intends to fix #97