Windows Python 3.7 .isfile() fix

[SSTato]

Signed-off-by: SSTato [email protected]

🛠️ PR Summary

_{Made with ❤️ by Ultralytics Actions}

🌟 Summary

Improved file existence checks in Ultralytics dataloaders and utility functions.

📊 Key Changes

• Modified the method of checking if a file exists from using Path.is_file() to os.path.isfile().
• Clarified and standardized the file existence validation across different parts of the code.

🎯 Purpose & Impact

• Consistency: Standardizing file checks makes the codebase more uniform and easier to maintain.
• Compatibility: The os module's file check methods are widely accepted, ensuring better compatibility across different operating systems.
• Reliability: These changes could increase the reliability of file handling within the toolkit, which benefits users in smoother data loading and processing.

[github-actions]

👋 Hello @SSTato, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

• ✅ Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
• ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
• ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

[SSTato]

Resolve Issue #9866

[glenn-jocher]

@SSTato I added Windows URL download test to CI in

yolov5/detect.py

Line 252 in eef9057

check_requirements(exclude=('tensorboard', 'thop'))

and observed no problems in Windows.

See #2

[SSTato]

I replaced my computer with a new one and downloaded the latest yolov5-master. He had no problem checking the pictures.

However, when I check the URL, I still make mistakes. The problem is still the line of code.

It does have problems with Windows 10, and I've tried it many times.
My new computer configuration is:
Windows 10 Python-3.7.10 torch-1.8.1+cu111 CUDA:0 (GeForce RTX 3060 Ti, 8192MiB)

[SSTato]

The problem is that the code 'Path(sources).is_file()' cannot run correctly on my computer. Replacing it with 'os.path.isfile(sources)' can solve this problem.
Other people have encountered the same problem and contacted me via email to solve it.

[glenn-jocher]

@SSTato I wonder if it's a Python 3.7 issue with Windows. I'll update the CI to 3.7 to see what happens.

[SSTato]

@SSTato I wonder if it's a Python 3.7 issue with Windows. I'll update the CI to 3.7 to see what happens.

Python 3.8 has the same problem

[glenn-jocher]

Ok yes I see that 3.7 Pathlib usage might not allow for .is_file()

I wonder if we can replace it with .exists()

[glenn-jocher]

@SSTato ok I've updated based on fixes in #2 that pass Windows 3.7, 3.8 CI. Can you try the PR now and let me know if this resolves your issue?

[SSTato]

@SSTato ok I've updated based on fixes in glenn-jocher#2 that pass Windows 3.7, 3.8 CI. Can you try the PR now and let me know if this resolves your issue?

I tested #2, which can be used in python 3.7. For ' python detect py --source https://ultralytics.com/images/zidane.jpg 'No problem

but when I' python detect py --source rtsp://admin:abc12345 @192.168.1.71/Streaming/Channels/1 ', it still has errors, and' dataloaders. py 'needs to be modified. After that, it has no errors.

[SSTato]

I can correctly run the code before the change on python 3.9, so it can be determined that the problem is the python version. There is no problem when the yolov5-master is above python 3.9, but there are problems I raised with python 3.7 and 3.8.

[glenn-jocher]

@SSTato PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐