Skip to content

Allow list for Comet artifact class 'names' field #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Allow list for Comet artifact class 'names' field #9654

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a709ba7
Update __init__.py
KristenKehrer Sep 29, 2022
97aed9c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2022
54de041
Update utils/loggers/comet/__init__.py
KristenKehrer Sep 30, 2022
fd2655d
Merge branch 'master' into patch-1
glenn-jocher Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion utils/loggers/comet/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,14 @@ def download_dataset_artifact(self, artifact_path):
metadata = logged_artifact.metadata
data_dict = metadata.copy()
data_dict["path"] = artifact_save_dir
data_dict["names"] = {int(k): v for k, v in metadata.get("names").items()}

metadata_names = metadata.get("names")
if type(metadata_names) == dict:
data_dict["names"] = {int(k): v for k, v in metadata.get("names").items()}
elif type(metadata_names) == list:
data_dict["names"] = {int(k): v for k, v in zip(range(len(metadata_names)), metadata_names)}
else:
raise "Invalid 'names' field in data.yml, has to be a list or dictionary"

data_dict = self.update_data_paths(data_dict)
return data_dict
Expand Down