Skip to content

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 29, 2022

No longer required with new built-in GitHub PR merge master feature

Signed-off-by: Glenn Jocher [email protected]

TODO:

  • Update PR message and contribute.md with new merge instructions.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Streamlining contribution workflow with updated GitHub Actions and contributions documentation.

📊 Key Changes

  • Removed detailed git command instructions from greetings.yml, simplifying the initial message to new PR submitters.
  • Deleted the rebase.yml GitHub Action which automated rebasing of PRs.
  • Updated CONTRIBUTING.md to guide contributors towards using the 'Update branch' button or local git commands for branch updates rather than the removed rebase option.

🎯 Purpose & Impact

  • Enhances clarity for new contributors by simplifying the welcome message for PRs.
  • Encourages manual updating of contributors' branches which may lead to a better understanding of the merge process.
  • Potential impact includes contributors needing to adapt to a change in the workflow, potentially improving their git skills. However, it could increase the learning curve for new contributors.

No longer required with new built-in GitHub PR merge master feature

Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher self-assigned this Aug 29, 2022
@glenn-jocher glenn-jocher merged commit f37ac8d into master Aug 30, 2022
@glenn-jocher glenn-jocher deleted the delete/rebase branch August 30, 2022 09:36
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Delete rebase.yml

No longer required with new built-in GitHub PR merge master feature

Signed-off-by: Glenn Jocher <[email protected]>

* Update CONTRIBUTING.md

Signed-off-by: Glenn Jocher <[email protected]>

* Update greetings.yml

Signed-off-by: Glenn Jocher <[email protected]>

* Update CONTRIBUTING.md

Signed-off-by: Glenn Jocher <[email protected]>

* cleanup

Signed-off-by: Glenn Jocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant