Skip to content

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 14, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved suffix checking logic in Ultralytics' utility functions.

πŸ“Š Key Changes

  • Updated the check_suffix function to handle file suffix checks more robustly.
  • Added a condition to ensure the suffix is non-empty before asserting it's in the allowed list.

🎯 Purpose & Impact

  • Purpose: To prevent potential bugs where an empty file suffix could cause incorrect assertions.
  • Impact: This change will lead to more accurate error messages and validation, ensuring users only process files with proper suffixes. For developers, the codebase becomes slightly more reliable and easier to maintain. πŸ› οΈβœ…

@glenn-jocher glenn-jocher merged commit 7ee5aed into master Oct 14, 2021
@glenn-jocher glenn-jocher deleted the update/check_suffix branch October 14, 2021 19:00
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Improved check_suffix() robustness to `''` and `""`

* Cleanup
@kennedyk1
Copy link

Hello! I had this problem on windows. I can't trainning my model without pre-trainned weights.

@glenn-jocher
Copy link
Member Author

@kennedyk1 hi there! It seems like you're encountering issues with training your model without pre-trained weights on Windows. Have you tried specifying the pre-trained weights in the command using the --weights flag? Also, ensure that the path to the pre-trained weights is correct. Let me know if you need further assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError: '' acceptable suffix is ['.pt'] AssertionError: '' acceptable suffix is ['.pt'] (Before running train.py)

2 participants