Skip to content

Improved check_requirements() robustness #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2021
Merged

Improved check_requirements() robustness #3298

merged 1 commit into from
May 23, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 23, 2021 •
edited by UltralyticsAssistant
Loading

Add try: except clause on missing requirements install to catch install failures. Prompted by Ultralytics YOLOv5 API failure on Cython #3297.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced error handling for dependency checks in YOLOv5 setup.

📊 Key Changes

  • Wrapped the automated pip install command in a try-except block.
  • Added error message printing upon installation failure.

🎯 Purpose & Impact

  • Benefit: Provides clearer feedback when automatic dependency installation encounters issues.
  • Impact: Users will have a better understanding of what went wrong during setup, improving user experience and troubleshooting.🛠️

@glenn-jocher
Improved check_requirements() robustness
c730c47 
Add try: except clause on missing requirements install to catch install failures. Prompted by Ultralytics YOLOv5 API failure on Cython.
@glenn-jocher glenn-jocher added the enhancement New feature or request label May 23, 2021
@glenn-jocher glenn-jocher self-assigned this May 23, 2021
@glenn-jocher glenn-jocher merged commit 9f3a388 into master May 23, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 23, 2021 16:00
@glenn-jocher glenn-jocher linked an issue May 23, 2021 that may be closed by this pull request
Make requirements installation optional #3094
Closed
@glenn-jocher glenn-jocher mentioned this pull request May 23, 2021
Closed
@glenn-jocher glenn-jocher linked an issue May 23, 2021 that may be closed by this pull request
Requirements: opencv-python>=4.1.2 not found and is required by YOLOv5 Jetson Nano #3073
Closed
@glenn-jocher glenn-jocher mentioned this pull request May 23, 2021
Closed
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
@glenn-jocher
Improved check_requirements() robustness (ultralytics#3298)
7ea8ef9 
Add try: except clause on missing requirements install to catch install failures. Prompted by Ultralytics YOLOv5 API failure on Cython.

(cherry picked from commit 9f3a388)
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
Improved check_requirements() robustness (ultralytics#3298)
3728452 
Add try: except clause on missing requirements install to catch install failures. Prompted by Ultralytics YOLOv5 API failure on Cython.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glenn-jocher glenn-jocher

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make requirements installation optional Requirements: opencv-python>=4.1.2 not found and is required by YOLOv5 Jetson Nano

1 participant

@glenn-jocher