Fixed Dataset.subset when buffer_size is None #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jindrahelcl
requested changes
Apr 23, 2019
Member
jindrahelcl
left a comment
jindrahelcl
left a comment
There was a problem hiding this comment.
na zjištění, jestli existujou buffer_size se používá self.lazy
varisd
force-pushed
the
dataset_subset_fix
branch
from
0e1557a to
9a9098d
Compare
Member
Author
|
ping |
jindrahelcl
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset.subset method was not working when Dataset wasn't initialized as lazy. This workaround fixes the problem.