Skip to content

Conversation

donovan-fournier
Copy link
Contributor

@donovan-fournier donovan-fournier commented Sep 9, 2025

Changes Overview

Fix edge case when a matching node is at pos 0

Implementation Approach

Increase early return check

Testing Done

Testable on Extensions/DragHandleWithNodeViews Link from last stable version PR

  • In current version, drag the NodeView at 1st pos
  • The handle is not displayed anymore

Verification Steps

  • Open Extensions/DragHandleWithNodeViews sample
  • The handle is properly displayed on 1st

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#6923
#6930

Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 08067ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 69 packages
Name Type
@tiptap/extension-drag-handle Patch
@tiptap/extension-drag-handle-react Patch
@tiptap/extension-drag-handle-vue-2 Patch
@tiptap/extension-drag-handle-vue-3 Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-caret Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-details Patch
@tiptap/extension-document Patch
@tiptap/extension-emoji Patch
@tiptap/extension-file-handler Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-font-family Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-invisible-characters Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list Patch
@tiptap/extension-mathematics Patch
@tiptap/extension-mention Patch
@tiptap/extension-node-range Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-of-contents Patch
@tiptap/extension-table Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-unique-id Patch
@tiptap/extension-youtube Patch
@tiptap/extensions Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/static-renderer Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch
@tiptap/extension-character-count Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-focus Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-history Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 08067ea
🔍 Latest deploy log https://app.netlify.com/projects/tiptap-embed/deploys/68cd00d6d83bbc0008e81117
😎 Deploy Preview https://deploy-preview-6931--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@donovan-fournier donovan-fournier force-pushed the fix/drag_handle_wrong_position branch from 7de951a to 08067ea Compare September 19, 2025 07:05
Copy link

pkg-pr-new bot commented Sep 19, 2025

Open in StackBlitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@6931

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@6931

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@6931

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@6931

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@6931

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@6931

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@6931

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@6931

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@6931

@tiptap/extension-collaboration-caret

npm i https://pkg.pr.new/@tiptap/extension-collaboration-caret@6931

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@6931

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@6931

@tiptap/extension-details

npm i https://pkg.pr.new/@tiptap/extension-details@6931

@tiptap/extension-drag-handle

npm i https://pkg.pr.new/@tiptap/extension-drag-handle@6931

@tiptap/extension-drag-handle-react

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-react@6931

@tiptap/extension-drag-handle-vue-2

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-2@6931

@tiptap/extension-drag-handle-vue-3

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-3@6931

@tiptap/extension-emoji

npm i https://pkg.pr.new/@tiptap/extension-emoji@6931

@tiptap/extension-file-handler

npm i https://pkg.pr.new/@tiptap/extension-file-handler@6931

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@6931

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@6931

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@6931

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@6931

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@6931

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@6931

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@6931

@tiptap/extension-invisible-characters

npm i https://pkg.pr.new/@tiptap/extension-invisible-characters@6931

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@6931

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@6931

@tiptap/extension-list

npm i https://pkg.pr.new/@tiptap/extension-list@6931

@tiptap/extension-mathematics

npm i https://pkg.pr.new/@tiptap/extension-mathematics@6931

@tiptap/extension-node-range

npm i https://pkg.pr.new/@tiptap/extension-node-range@6931

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@6931

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@6931

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@6931

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@6931

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@6931

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@6931

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@6931

@tiptap/extension-table-of-contents

npm i https://pkg.pr.new/@tiptap/extension-table-of-contents@6931

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@6931

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@6931

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@6931

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@6931

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@6931

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@6931

@tiptap/extension-unique-id

npm i https://pkg.pr.new/@tiptap/extension-unique-id@6931

@tiptap/extensions

npm i https://pkg.pr.new/@tiptap/extensions@6931

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@6931

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@6931

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@6931

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@6931

@tiptap/static-renderer

npm i https://pkg.pr.new/@tiptap/static-renderer@6931

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@6931

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@6931

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@6931

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@6931

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@6931

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@6931

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@6931

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@6931

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@6931

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@6931

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@6931

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@6931

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@6931

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@6931

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@6931

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@6931

commit: 08067ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant