Skip to content

fix(extension-redis): unsubscribe from pubsub #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

tomi-bigpi
Copy link
Contributor

Fixes an issue where Redis PubSub is not unsubscribed due to delayed disconnect logic.

The Redis subscription unsubscribe code is behind a setTimeout which checks if the document instance is still available on the parent instance, which for us is never since the document is disposed by the time the setTimeout code is called.

Additionally, the existing unloadDocument call is suspect, but I left it in with a check for a valid document instance.

@janthurau janthurau merged commit 0812d48 into ueberdosis:main Jul 19, 2025
@janthurau
Copy link
Collaborator

Thank you!

@fuadsaud
Copy link

fuadsaud commented Aug 3, 2025

Shouldn't redis unsubscribe on afterUnloadDocument?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants