-
Notifications
You must be signed in to change notification settings - Fork 0
Get real project to run through Prefect #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get real project to run through Prefect #56
Conversation
More in line with omop_es cli args
Better UX when creating runs through Prefect UI
Next stage will still bootstrap itself and install `renv` as it's not available for `docker` user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates a real project (hic_cc) to run through Prefect with separate dev/prod deployments. The changes enhance the Prefect workflow system with better logging, improved argument handling, and production deployment support.
- Adds separate
devandproddeployment configurations for Prefect flows - Improves logging to handle
[WARN]and[CRITICAL]log levels - Enhances Docker build process with better branch handling and caching
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| template.env | Adds OMOP_ES_BRANCH configuration variable |
| prefect/test_subprocess_utilities.py | Updates tests for enhanced log level handling |
| prefect/test_run_omop_es.py | Adds test for prod deployment flag and fixes parameter name |
| prefect/run_subprocess.py | Enhances log level parsing to support WARN and CRITICAL levels |
| prefect/run_omop_es.py | Refactors flow with better parameter types and prod deployment support |
| prefect/prefect.yaml | Configures separate dev and prod deployments |
| prefect/Makefile | Updates make targets for improved workflow management |
| docker/Dockerfile | Improves Docker build process with better dependency handling |
| docker-compose.yml | Adds cache busting for Docker builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Barring some |
Co-authored-by: Copilot <[email protected]>
I've created a new PR to update the OMOP vocabs version in OMOP_ES |
Seems flaky and makes server die for unclear reason
stefpiatek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
Reasonably confident it's doing the correct thing now: http://uclvlddpragae10:8082/runs/flow-run/37b16ef1-24ae-4303-8183-4e53acc9fc23 |
hic_ccproject on GAE with Prefectdevandproddeployments (closes DEP-46, Use a single deployment foromop_esruns #55)MakefileandDockerfiletweaks[WARN]and[CRITICAL]Closes DEP-42, #52