Update merge commit title to mimic github's pattern #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganemone
previously approved these changes
May 31, 2019
|
The commit title GitHub uses is actually just the number, not the URL. This works nicely for the GitHub UI but is less good for viewing commits locally. I think the reasoning for using the full URL being able to click to the PR using most terminals when looking at commits locally. And because the full URL is long, that is why it is in the description rather than the title itself. Perhaps we should do both, to get best of both worlds: |
|
@rtsao makes sense; updated. Will also update sync probot to match this |
rtsao
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
New:
In the UI, github dynamically replaces the full url with the shorthand; e.g.My title (https://github.com/foo/bar/pull/0)shows up asMy title (#0).I'm using this pattern in the sync probot, so just wanted it to be consistent