Filter lists are considered out of date in incognito mode

[okiehsch]

Prerequisites

• [x ] I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• [x ] This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• [ x] I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • [x ] uBlock Origin is the only extension
  • [x ] uBlock Origin with default lists/settings
  • [x ] using a new, unmodified browser profile
• [x ] I am running the latest version of uBlock Origin
• [x ] I checked the documentation to understand that the issue I report is not a normal behavior

Description

Filter lists are always considered out of date if you open a new incognito mode window in Chrome.
Worked fine with 1.17.4

Steps to Reproduce

1. Open a new browser session using Chrome
2. Make sure that all Filter lists are up to date
3. Open a new incognito window
4. Open the Filter lists tab in the dashboard

Expected behavior:

Actual behavior:

Your environment

• uBlock Origin version: 1.18.0
• Browser Name and version: Chrome 71
• Operating System and version: Windows 10

[gorhill]

Ugh... that's bad, especially finding this right after the release.

[okiehsch]

That's why you do a staged rollout 😉
Firefox works fine.

[gorhill]

Currently the stage is 6% of 10,000,000+, not good.

Especially that there is no easy solution for this. I can fix it by removing "incognito": "split" in the manifest, but then the "document blocked" page can no longer be loaded in incognito mode. The only fix possible is to remove support for IndexedDB, hence support for compression.

[gorhill]

@okiehsch Is it something that was reported elsewhere or you just stumbled on it?

[okiehsch]

I stumbled on it, I only used the dev version with Firefox, so today was the first time that I used 1.18.0 with my laptop.

[uBlock-user]

How is it that it's only happening with this release and didn't occur before ?

[gorhill]

How do you conclude it did not occur before? I am sure it did occur, it just happened nobody stumbled on it. I don't use incognito myself, Chromium is not my main browser, I just test/debug uBO with it.

[okiehsch]

I meant that I only used the dev version with Chrome to check for some obvious bugs concerning the logger and such.
I always used the stable/Chromium version with my productive setups.

[okiehsch]

The filter lists are not really out of date and the users will have the newest filters, so technically it is not a big deal but there will be complaints.

[gorhill]

The filter lists are not really out of date

I am sure they are out of date, Chromium is creating a whole new IndexedDB for the incognito process of uBO. I have no choice but to revert back to chrome.storage.local -- which is a trivial fix in itself but we now lose LZ4 compression in Chromium. With non-trivial work I could support LZ4 for chrome.storage.local but not sure this will be worth it efficiency-wise.

[gorhill]

If using spanning mode, the IndexedDB can be shared in incognito windows, but this causes this issue: uBlock-LLC/uBlock#1225.

[okiehsch]

I am sure they are out of date

I see, so the filter list version of the incognito window would always be the one of the time I opened the new browser session.

[gorhill]

It would be the lists from the package, or there would be a fetch to a remote server for the ones selected which are not in the package.