Handle nodes without coordinates #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat nodes without coordinates the same as if they are absent, in construct_multipolygon, construct_multilinestring, and when processing ways, to avoid producing coordinates of NaN/null. When a segment of a relation (either a line string, or a polygon ring) consists entirely of invalid nodes, omit this empty array, to avoid producing a coordinates element which is an empty array. Both of these changes will cause such features to be omitted from the output when they have no coordinates, just as they already are for ways which reference nodes that are absent, and relations which reference ways that are absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node has no coordinates, treat it as missing for the purpose of constructing the multilinestring, multipolygon, or way geometry, to avoid producing coordinates of [NaN, NaN].
When a piece of a multipolygon or multilinestring contains no coordinates, remove it, to avoid inserting an empty array into the coordinates array.
Fixes #142