Format groovy files #7202
Closed
Format groovy files #7202
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
msridhar
reviewed
Aug 14, 2025
| @@ -332,39 +332,36 @@ allprojects { currentProj -> | |||
| formatAnnotations() | |||
| } | |||
|
|
|||
| // Only define a groovyGradle task on the root project, for simplicity in setting the target pattern | |||
| if (currentProj == currentProj.rootProject) { | |||
There was a problem hiding this comment.
Not sure removing this check is right, in that I'm not sure all build.gradle files in nested directories will still be formatted. Is the issue here that the top-level build.gradle file was not getting formatted?
Also if I recall correctly tweaking these settings can have significant impacts on incremental build performance so we should test that.
There was a problem hiding this comment.
Hmm, I was seeing that problem, but I can no longer reproduce it. So I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.