-
Notifications
You must be signed in to change notification settings - Fork 376
Change release process to account for putting AFU in CF repo. #7185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…amework into clean-up-release-test
release.gradle
Outdated
|
||
ext { | ||
currentDate = LocalDateTime.now().format(DateTimeFormatter.ofPattern("d MMM yyyy")) | ||
releaseVersionRegex = "\\d\\.\\d+\\.\\d+(?:\\.\\d)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asking why the regex isn't ""\d\.\d+\.\d+(?:\.\d)?". The "?" you referred to isn't an operator; rather, "?:" is an operator.
|
||
filter { String line -> | ||
line = line.replaceAll("checker-framework-${releaseVersionRegex}{0,1}", "checker-framework-${releaseVersion}") | ||
line.replaceAll("<!-- checker-framework-date -->(.*)<!-- /checker-framework-date -->", "<!-- checker-framework-date -->${currentDate}<!-- /checker-framework-date -->") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings are used twice, so put them in variables rather than duplicating them.
'manual/introduction.tex' | ||
|
||
filter { String line -> | ||
line = line.replaceAll("checker-framework-${releaseVersionRegex}", "checker-framework-${releaseVersion}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can use the same regular expression as on line 61; you can abstract the two strings on that line into variables and use them here and there.
} | ||
|
||
tasks.register('updateCopyMavenExample', Copy) { | ||
String destDir = project.property('destDir') + '/MavenExample' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copies to destDir
, unlike other copy tasks. That should at least be documented.
…amework into clean-up-release-test
…amework into clean-up-release-test
I used this branch to create the dev website here: https://checkerframework.org/dev/
Moved the following files (in the repo):
Changes to the release zip files:
New layout of checker-framework.zip:
Removed all the ant build files and replaced them with Gradle tasks.
Updated the release scripts to use
central.sonatype.com
.