-
Notifications
You must be signed in to change notification settings - Fork 376
Migrate JavaParser-Based Expression Parsing to Javac API #7176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
akulk022
wants to merge
80
commits into
typetools:master
Choose a base branch
from
akulk022:javaParser_replacement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework into javaParser_replacement
…aParser_replacement
…oJavaExpression visitor
…logic in visitIdentifier
…aParser_replacement
This reverts commit bf48bab.
… javaParser_replacement
… javaParser_replacement
… javaParser_replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a complete replacement of the JavaParser-based expression parsing pipeline in
JavaExpressionParseUtil
with an implementation based on the standard javac API (com.sun.source.tree.*
).A brief overview of the updated implementation details:
JavacParseUtil
to programmatically parse string expressions intocom.sun.source.tree.ExpressionTree
nodes.ExpressionTreeToJavaExpressionVisitor
, a visitor that mirrors the logic of the originalExpressionToJavaExpressionVisitor
.Unit testing was successful on the new changes by running
JavaExpressionCheckerTest
and the overall framework tests.