Skip to content

Make JavaExpressionParseUtil handle ConditionalExpression #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Make JavaExpressionParseUtil handle ConditionalExpression #7045

wants to merge 13 commits into from

Conversation

mernst
Copy link
Member

@mernst mernst commented Apr 17, 2025 •
edited
Loading

Merge before fix for #6520.
The test for this appears in the fix for #6520.

smillst
smillst requested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this is related to #6520. Are you trying to parser all possible JavaExpressions? I looked in to how to fix #6750, which I just noticed is a duplicate of #6520, and think that the in come cases we should infer top rather than an annotation with a parse error. I've implemented this in #7052.

framework/src/main/java/org/checkerframework/framework/util/JavaExpressionParseUtil.java
}
}
// Now `type` is set.
return new Unknown(type, expr.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return a new JavaExpression for conditional expressions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does such an expression exist? I was trying to avoid implementing it if possible, though I could do so.

@smillst smillst assigned mernst and unassigned smillst Apr 21, 2025
@mernst
Copy link
Member Author

mernst commented Apr 22, 2025

My fix for #6520 (in my issue6520 branch) happens to parse more expressions. This is an attempt to make the code behave a bit better for certain expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillst smillst smillst requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mernst mernst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mernst @smillst