Skip to content

fix: overwrite validation decorators from parent class when defined i… #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: overwrite validation decorators from parent class when defined i… #2641

wants to merge 1 commit into from

Conversation

@rdubigny
Copy link

@rdubigny rdubigny commented Nov 7, 2025 •
edited
Loading

Description

This is an updated rebase of #748 .

Fixes a bug that caused decorated properties which are also decorated in inherited classes, to skip their inherited validation.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #633 , fixes #622

@rdubigny rdubigny mentioned this pull request Nov 13, 2025
Open
6 tasks
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
6c6bb3d 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" tarball approach.
This should push us toward eventually migrating to another validation
library such as Zod.
@rdubigny rdubigny mentioned this pull request Nov 14, 2025
Merged
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
8c24645 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
701fa13 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
c458704 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
661e419 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.
rdubigny added a commit to proconnect-gouv/federation that referenced this pull request Nov 14, 2025
@rdubigny
📦 Use forked class-validator package
5151c10 
**Problem**
They are inheritance issues in `class-validator` (see issue:
typestack/class-validator#633).

We updated a PR to fix this problem:
typestack/class-validator#2641.

However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.

**Proposal**
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inheriting Validation decorators The names of the decorators are lost in the MetadataStorage

1 participant

@rdubigny