-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
(Related to #90)
Maybe we should create bots that notify us when a typeshed pull request affects the dependencies of popular packages? If one of those dependencies gets hacked, many people and servers will install the malware, so changing those dependencies (sometimes in surprising indirect ways) should be seen as a red flag.
Some ideas:
- If a typeshed pull request affects which packages
pip install types-requestspulls in, then a bot posts a comment saying that nowtypes-requestsindirectly depends onfoo. - If a typeshed pull requests causes
pip install types-requeststo pull in something it didn't pull in before, then a bot marks that PR with a label so maintainers will review it extra carefully. - If a typeshed pull requests causes
pip install types-requeststo pull in something it didn't pull in before, then two typeshed maintainers need to approve the PR before it can be merged. (I haven't looked into ways to enforce this.)
I am following our "convention" of using types-requests as an example of a popular package, but the same would apply to other popular packages, basically anything with more than x weekly/monthly/yearly downloads.
Metadata
Metadata
Assignees
Labels
No labels