Skip to content

Conversation

@gemelen
Copy link
Collaborator

@gemelen gemelen commented Dec 4, 2021

@gemelen
Copy link
Collaborator Author

gemelen commented Jan 19, 2022

Ok, back to business :)
DiesSuite fails on serde tests of Diet object, specifically on all its Discrete internal objects (ie not all components of internal state of Diet are serializable by default). If Discrete trait is marked as a Serializabe, then tests pass successfully.

So, question is, are we allowed to make Discrete Serializable (I doubt so, but still want to ask)?
@danicheg @osleonard what do you think?

@johnynek
Copy link
Contributor

Why wouldn't you want to mark it serializable? Java Serialization is rather broken but useful for systems that serialize closures (like spark, flink, etc...)

I would add the extends Serializable without worrying very much.

@danicheg
Copy link
Member

If MiMa is not arguing against it, I vote to add that extends too.

@gemelen
Copy link
Collaborator Author

gemelen commented Jan 20, 2022

Why wouldn't you want to mark it serializable? Java Serialization is rather broken but useful for systems that serialize closures (like spark, flink, etc...)

I would add the extends Serializable without worrying very much.

FIrst of all because I consider Discrete as a public API (both in sense of being used by other parts in this library and by end-users), which I may not change that free.

On the other hand, if I'm too strict with this and we could make it Serializable, it makes intended upgrade easier.

Marking `Discrete` serializable to specify that objects that has it in
their inner state could serialize it.
@gemelen gemelen merged commit b16b87f into typelevel:master Jan 21, 2022
@gemelen gemelen deleted the steward/algebra-2.7.0 branch January 22, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants