Use MUnit in tests #412
Use MUnit in tests #412
Conversation
| Gen.choose(0, limit).flatMap(heapGen[Int](_, Arbitrary.arbitrary[Int])) | ||
|
|
||
| property("PairingHeap.combineAll (remove) does < log_2 N + 8 work") = | ||
| forAll(genPairingHeapLimitedSize(10)) { heap: PairingHeap[Int] => |
There was a problem hiding this comment.
In the previous version based on Scalatest, the heap have generated with max size 10 (although there is no explicit limit in Gen[A] I saw it when the manually printing size of the heap). So, I've added the explicit limit on heap size because it often was a length bigger than 10 in the new version based on MUnit.
|
It'd be nice if you can check this @gemelen, @lukoyanov, @osleonard. We're getting closer to unify test-framework in |
Will take a look, later in the evening |
|
@danicheg I've already looked over, but stopped due lack of CI runs and was looking to fix that. |
|
CI didn't run because @danicheg is a first-time contributor, and GitHub added the anti-mining protections. I'm not sure why that didn't show up as the typical "Approve and Run" button here. Anyway, I kicked it off, and you can see it here. This will happen again if another commit is pushed to this PR, until @danicheg gets one merged. I think @osleonard and @gemelen would have permissions to kick it off. If not, I'll look deeper into why not. |
|
It seems workflow needs to be regenerated. And then it's needed to run CI pipeline yet another time for this PR. |
|
I suggest to rebase this branch |
Done. Though there were no conflicts. |
|
It looks like there are no blockers to merge this. And there is a chance that will also fix #425. |
Yeap will merge this now. |
|
@osleonard thanks! |
4 participants
This PR aims to unify the test framework in
cats-based projects intypelevelorg.It is worth mentioning - test running time have increased. I've tried to figure out a reason, but it needs more investigation.