Fix the warnings and enable fatal warnings in CI

[armanbilge]

Follow-up to #485.

cats-collections/build.sbt

Line 17 in 2bf3b43

ThisBuild / tlFatalWarningsInCi := false

[satorg]

@armanbilge @gemelen may I take this one?

[PATIENCE-ONAH]

Hi @armanbilge, it seems this issue has been resolved as there were no warnings after I ran test. Do I go ahead and enable fatal warning or maybe I'm missing something.

[armanbilge]

Hi @PATIENCE-ONAH, thanks for your interest!

it seems this issue has been resolved

Unfortunately not, this issue has still not been resolved.

there were no warnings after I ran test

The warnings occur before running tests, during the compilation phase. You can see them here in CI:
https://github.com/typelevel/cats-collections/actions/runs/18596764558/job/53024923908#step:12:25

[satorg]

Ah yeah, this one... I started off briskly and fixed some of the files. Then got stuck with TreeList. I don't remember what the issue was exactly since it was quite long ago. Perhaps, there were differences between Scala2 and Scala3 compilers that I didn't manage to overcome.

[PATIENCE-ONAH]

Hi @PATIENCE-ONAH, thanks for your interest!

it seems this issue has been resolved

Unfortunately not, this issue has still not been resolved.

there were no warnings after I ran test

The warnings occur before running tests, during the compilation phase. You can see them here in CI: https://github.com/typelevel/cats-collections/actions/runs/18596764558/job/53024923908#step:12:25

Okay, Thank you. I will look at it again