Skip to content

some useful improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akellne wants to merge 2 commits into
base: master
Choose a base branch
from
Open

some useful improvements #5

akellne wants to merge 2 commits into from

Conversation

@akellne
Copy link

@akellne akellne commented May 20, 2016

Some minor additions to the existing prompters such as forcing an input, plus two new prompters to obtain a file or a directory.

Ansgar Kellner added 2 commits May 20, 2016 13:14
* added required_input parameter to prompt() for forcing an input
3e0a966 
* changed default of yesno() to None so that input is required by default
* yesno() returns True for 'yes' and False for 'no', default is not relevant
* some PEP8 fixes
added two additional prompter for getting a file or a directory (with…
8e7a2fb 
… tab-completion)
@tylerdave
Copy link
Owner

tylerdave commented Mar 18, 2017

I somehow missed this when you submitted!

A few things:

  • Tests are failing as-is. They need to be made to pass or if the functionality is changing the tests need to be updated.
  • New functionality needs tests
  • Minor: There's no need for the change to multi-line docstrings in most cases here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akellne @tylerdave