[TEP-0056]: Pipelines in Pipelines happy path using PipelineSpec property.

examples/v1/pipelineruns/alpha/pipelinerun-with-pinp-in-pipelinespec.yaml

@@ -0,0 +1,23 @@
+apiVersion: tekton.dev/v1
+kind: Pipeline
+metadata:
+  name: pip-parent
+spec:
+  tasks:
+    - name: pip-child
+      pipelineSpec:
+        tasks:
+          - name: pip-child-task
+            taskSpec:
+              steps:
+                - name: hello-pip
+                  image: mirror.gcr.io/alpine
+                  script: echo "Hello from pip!"
+---
+apiVersion: tekton.dev/v1
+kind: PipelineRun
+metadata:
+  generateName: pip-parent-run-
+spec:
+  pipelineRef:
+    name: pip-parent

pkg/apis/pipeline/v1/pipelinerun_types.go

@@ -84,6 +84,16 @@ func (pr *PipelineRun) HasStarted() bool {
 	return pr.Status.StartTime != nil && !pr.Status.StartTime.IsZero()
 }
 
+// IsSuccessful returns true if the PipelineRun's status indicates that it has succeeded.
+func (pr *PipelineRun) IsSuccessful() bool {
+	return pr != nil && pr.Status.GetCondition(apis.ConditionSucceeded).IsTrue()
+}
+
+// IsFailure returns true if the PipelineRun's status indicates that it has failed.
+func (pr *PipelineRun) IsFailure() bool {
+	return pr != nil && pr.Status.GetCondition(apis.ConditionSucceeded).IsFalse()
+}
+
 // IsCancelled returns true if the PipelineRun's spec status is set to Cancelled state
 func (pr *PipelineRun) IsCancelled() bool {
 	return pr.Spec.Status == PipelineRunSpecStatusCancelled

pkg/apis/pipeline/v1/pipelinerun_types_test.go

@@ -781,3 +781,83 @@ func TestPipelineRunMarkFailedCondition(t *testing.T) {
 		})
 	}
 }
+
+func TestPipelineRunIsSuccessful(t *testing.T) {
+	tcs := []struct {
+		name        string
+		pipelineRun *v1.PipelineRun
+		want        bool
+	}{{
+		name: "nil pipelinerun",
+		want: false,
+	}, {
+		name: "still running",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionUnknown,
+		}}}}},
+		want: false,
+	}, {
+		name: "succeeded",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionTrue,
+		}}}}},
+		want: true,
+	}, {
+		name: "failed",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionFalse,
+		}}}}},
+		want: false,
+	}}
+	for _, tc := range tcs {
+		t.Run(tc.name, func(t *testing.T) {
+			got := tc.pipelineRun.IsSuccessful()
+			if tc.want != got {
+				t.Errorf("wanted IsSuccessful to be %t but was %t", tc.want, got)
+			}
+		})
+	}
+}
+
+func TestPipelineRunIsFailure(t *testing.T) {
+	tcs := []struct {
+		name        string
+		pipelineRun *v1.PipelineRun
+		want        bool
+	}{{
+		name: "nil pipelinerun",
+		want: false,
+	}, {
+		name: "still running",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionUnknown,
+		}}}}},
+		want: false,
+	}, {
+		name: "succeeded",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionTrue,
+		}}}}},
+		want: false,
+	}, {
+		name: "failed",
+		pipelineRun: &v1.PipelineRun{Status: v1.PipelineRunStatus{Status: duckv1.Status{Conditions: []apis.Condition{{
+			Type:   apis.ConditionSucceeded,
+			Status: corev1.ConditionFalse,
+		}}}}},
+		want: true,
+	}}
+	for _, tc := range tcs {
+		t.Run(tc.name, func(t *testing.T) {
+			got := tc.pipelineRun.IsFailure()
+			if tc.want != got {
+				t.Errorf("wanted IsFailure to be %t but was %t", tc.want, got)
+			}
+		})
+	}
+}

pkg/pod/pod_test.go

@@ -2622,7 +2622,6 @@ _EOF_
 			} else {
 				trAnnotations = c.trAnnotation
 				trAnnotations[ReleaseAnnotation] = fakeVersion
-
 			}
 			testTaskRunName := taskRunName
 			if c.trName != "" {

pkg/reconciler/pipelinerun/controller.go

@@ -100,6 +100,13 @@ func NewController(opts *pipeline.Options, clock clock.PassiveClock) func(contex
 			logging.FromContext(ctx).Panicf("Couldn't register PipelineRun informer event handler: %w", err)
 		}
 
+		if _, err := pipelineRunInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+			FilterFunc: controller.FilterController(&v1.PipelineRun{}),
+			Handler:    controller.HandleAll(impl.EnqueueControllerOf),
+		}); err != nil {
+			logging.FromContext(ctx).Panicf("Couldn't register PipelineRun informer event handler: %w", err)
+		}
+
 		if _, err := taskRunInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
 			FilterFunc: controller.FilterController(&v1.PipelineRun{}),
 			Handler:    controller.HandleAll(impl.EnqueueControllerOf),