Skip to content

Conversation

@johnynek
Copy link
Collaborator

@johnynek johnynek commented Feb 2, 2016

No description provided.

@rubanm
Copy link
Contributor

rubanm commented Feb 2, 2016

LGTM

@rubanm
Copy link
Contributor

rubanm commented Feb 2, 2016

Looks like this failed because we refer to the Build.scala file in our sbt assembly scripts and also scald.rb

The command "scripts/build_assembly_no_test.sh scalding-repl" exited with 2.

0.08s$ scripts/test_repl_tutorial.sh

using TRAVIS_SCALA_VERSION 2.10.6

/home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/open-uri.rb:35:in `initialize': No such file or directory - /home/travis/build/twitter/scalding/project/Build.scala (Errno::ENOENT)

    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/open-uri.rb:35:in `open'

    from /home/travis/.rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/open-uri.rb:35:in `open'

    from /home/travis/build/twitter/scalding/scripts/scald.rb:60:in `<main>'

The command "scripts/test_repl_tutorial.sh" exited with 127.

0.01s$ scripts/build_assembly_no_test.sh scalding-core

sed: can't read project/Build.scala: No such file or directory

@rubanm
Copy link
Contributor

rubanm commented Feb 2, 2016

Fixed and restarted build.

@ianoc
Copy link
Collaborator

ianoc commented Feb 2, 2016

Updated for the parquet cascading change.

one thing before merge presuming green is do we know where the other version of algebird-core is coming from, from my build:

[warn]  * com.twitter:algebird-core_2.11:0.10.0 -> 0.11.0
[warn]  * org.apache.thrift:libthrift:0.5.0 -> 0.7.0

@ianoc
Copy link
Collaborator

ianoc commented Feb 2, 2016

[info] com.twitter:algebird-core_2.11:0.10.0 (evicted by: 0.11.0)
[info]   +-com.twitter:chill-algebird_2.11:0.7.1 [S]
[info]   | +-com.twitter:scalding-core_2.11:0.15.1-SNAPSHOT [S]
[info]   | 
[info]   +-com.twitter:scalding-core_2.11:0.15.1-SNAPSHOT [S]

That maybe is a bit confusing to parse to me in that it implies i think that scalding-core directly depends on this version which I can't see how it does. But chill-algebird does since we haven't gotten to the bump there

@johnynek
Copy link
Collaborator Author

johnynek commented Feb 2, 2016

about thrift, shouldn't that be provided maybe? We don't want to bump that, do we?

@johnynek
Copy link
Collaborator Author

johnynek commented Feb 2, 2016

also need new algebird and bijection, right?

@ianoc
Copy link
Collaborator

ianoc commented Feb 2, 2016

I had honestly presumed you had already done that since i was getting warnings about potential incompatible algebird versions in the build

@johnynek
Copy link
Collaborator Author

johnynek commented Feb 2, 2016

@ianoc I guess that was transitive from chill

@ianoc
Copy link
Collaborator

ianoc commented Feb 2, 2016

Yeah chill must have been another version back of algebird :/

johnynek added a commit that referenced this pull request Feb 2, 2016
@johnynek johnynek merged commit 26abfc6 into develop Feb 2, 2016
@johnynek johnynek deleted the oscar/updatebuild branch February 2, 2016 21:48
rubanm pushed a commit that referenced this pull request Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants