Skip to content

move version into pyproject.toml #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 1, 2024
Merged

move version into pyproject.toml #640

merged 6 commits into from
Aug 1, 2024

Conversation

sigma67
Copy link
Contributor

@sigma67 sigma67 commented Aug 1, 2024

Description

Fixes #<!-- add the associated GitHub Issue ID>

Checklist

  • [x ] Make sure changes are covered by existing or new tests.
  • [ x] For at least one Python version, make sure test pass on your local environment.
  • [x ] Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • [x ] Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • [x ] Ensure docs/tutorial.rst is still up-to-date.
  • [- ] If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • [x ] If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@sigma67 sigma67 requested a review from a team as a code owner August 1, 2024 08:51
@sigma67
Copy link
Contributor Author

sigma67 commented Aug 1, 2024

@adiroiban as requested this is the separate PR to move the version into pyproject.toml.

I suggest we also remove the deprecated __version__ attribute as it has been deprecated for three releases now.

@sigma67 sigma67 force-pushed the move-version-pyproject branch from 4d97dd5 to b1f92e7 Compare August 1, 2024 09:14
adiroiban
adiroiban reviewed Aug 1, 2024
View reviewed changes
adiroiban
adiroiban requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks very good.

Just a comment regarding _get_metadata_version and the removal information should have a separate fragment.

Other than that, all good.

Thanks again

src/towncrier/_project.py Outdated
@@ -67,6 +69,10 @@ def get_version(package_dir: str, package: str) -> str:
if version := _get_metadata_version(package):
return version

with contextlib.suppress(PackageNotFoundError):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this code?

What does it to, on top of the existing _get_metadata_version ?

Maybe move this to _get_metadata_version

If this needs to stay here, then it needs a comment to explain why _get_metadata_version is not good enough here and why we get the version again via `importlib.metadata.

Copy link
Contributor Author

@sigma67 sigma67 Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test test_version_from_metadata will fail without this code.

The existing function _get_metadata_version_ uses importlib.metadata.packages_distributions, which seems to not contain towncrier at test runtime. Not sure why, but I also don't know why this method of getting the version is used instead of straight up passing package to importlib.metadata.version.

I can move the check into the function, maybe inside the if not distribution_names block. Not sure.

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that _get_metadata_version should do everything.

So the code should be moved there.

Maybe also remove importlib.metadata.packages_distributions and replace it with the current method.

Do we need both methods? Just asking.

I am not very familiar with the importlib API ... but as long as the tests pass, we should be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I thought there might be some reason why it was done this way.

I replaced it as you suggested.

adiroiban
adiroiban reviewed Aug 1, 2024
View reviewed changes
src/towncrier/newsfragments/640.misc Outdated
@@ -0,0 +1,4 @@
Moved towncrier version definition from src/towncrier/_version.py to pyproject.toml

towncrier.__version__ was removed, after being deprecated in 23.6.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 lines needs to be in a separate newsfragment file of type .removal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

adiroiban
adiroiban approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

We should not worry about keeping "zombie" code.

If we think that some part of the code is not needed, we should just delete it.

As long as the tests still pass, it should be ok.

@adiroiban adiroiban merged commit fc3a255 into twisted:trunk Aug 1, 2024
16 checks passed
github-actions bot pushed a commit to aio-libs/aiohttp that referenced this pull request Jun 13, 2025
@dependabot
Bump towncrier from 23.11.0 to 24.8.0 (#11208)
e052a17 
Bumps [towncrier](https://github.com/twisted/towncrier) from 23.11.0 to
24.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 24.8.0 (2024-08-23)</h2>
<h3>Features</h3>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/643">#643</a>)</li>
<li>Config <!-- raw HTML omitted -->ignore<!-- raw HTML omitted -->
option now supports
wildcard matching via
<a
href="https://docs.python.org/3/library/fnmatch.html#fnmatch.fnmatch">fnmatch</a>.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/644">#644</a>)</li>
<li>Add a config for enforcing issue names using regex.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/649">#649</a>)</li>
</ul>
<h3>Bugfixes</h3>
<ul>
<li>The template file is now ignored based only on the file name.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/638">#638</a>)</li>
<li>Control of the header formatting is once again completely up to the
user when they are writing markdown files (fixes a regression
introduced in
[#610](<a
href="https://redirect.github.com/twisted/towncrier/pull/610">twisted/towncrier#610</a>)).
(<a
href="https://redirect.github.com/twisted/towncrier/issues/651">#651</a>)</li>
<li>Fixed an issue where <!-- raw HTML omitted -->issue_template<!-- raw
HTML omitted -->
failed recognizing the issue name of files with a non-category
suffix (<!-- raw HTML omitted -->.md<!-- raw HTML omitted -->)
(<a
href="https://redirect.github.com/twisted/towncrier/issues/654">#654</a>)</li>
<li>Fixed a bug where orphan news fragments (e.g. +abc1234.feature)
would fail when an <!-- raw HTML omitted -->issue_pattern<!-- raw HTML
omitted --> is
configured. Orphan news fragments are now excempt from <!-- raw HTML
omitted -->issue_pattern<!-- raw HTML omitted --> checks.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/655">#655</a>)</li>
</ul>
<h3>Deprecations and Removals</h3>
<ul>
<li>
<p>Moved towncrier version definition from src/towncrier/_version.py
to pyproject.toml</p>
<p>towncrier.__version__ was removed, after being deprecated in
23.6.0. (<a
href="https://redirect.github.com/twisted/towncrier/issues/640">#640</a>)</p>
</li>
</ul>
<h3>Misc</h3>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/640">#640</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/657">#657</a></li>
</ul>
<h2>Towncrier 24.8.0rc1 (2024-08-19)</h2>
<h3>Features</h3>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>Towncrier 24.8.0 (2024-08-23)</h1>
<p>No changes since the previous release candidate.</p>
<h2>Features</h2>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.
(<code>[#643](twisted/towncrier#643)
&lt;https://github.com/twisted/towncrier/issues/643&gt;</code>_)</li>
<li>Config <code>ignore</code> option now supports wildcard matching via
<code>fnmatch
&lt;https://docs.python.org/3/library/fnmatch.html#fnmatch.fnmatch&gt;</code><em>.
(<code>[#644](twisted/towncrier#644)
&lt;https://github.com/twisted/towncrier/issues/644&gt;</code></em>)</li>
<li>Add a config for enforcing issue names using regex.
(<code>[#649](twisted/towncrier#649)
&lt;https://github.com/twisted/towncrier/issues/649&gt;</code>_)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>The template file is now ignored based only on the file name.
(<code>[#638](twisted/towncrier#638)
&lt;https://github.com/twisted/towncrier/issues/638&gt;</code>_)</li>
<li>Control of the header formatting is once again completely up to the
user when they are writing markdown files (fixes a regression introduced
in <a
href="https://redirect.github.com/twisted/towncrier/pull/610">#610</a>).
(<code>[#651](twisted/towncrier#651)
&lt;https://github.com/twisted/towncrier/issues/651&gt;</code>_)</li>
<li>Fixed an issue where <code>issue_template</code> failed recognizing
the issue name of files with a non-category suffix (<code>.md</code>)
(<code>[#654](twisted/towncrier#654)
&lt;https://github.com/twisted/towncrier/issues/654&gt;</code>_)</li>
<li>Fixed a bug where orphan news fragments (e.g. +abc1234.feature)
would fail when an <code>issue_pattern</code> is configured. Orphan news
fragments are now excempt from <code>issue_pattern</code> checks.
(<code>[#655](twisted/towncrier#655)
&lt;https://github.com/twisted/towncrier/issues/655&gt;</code>_)</li>
</ul>
<h2>Deprecations and Removals</h2>
<ul>
<li>
<p>Moved towncrier version definition from src/towncrier/_version.py to
pyproject.toml</p>
<p>towncrier.<strong>version</strong> was removed, after being
deprecated in 23.6.0.
(<code>[#640](twisted/towncrier#640)
&lt;https://github.com/twisted/towncrier/issues/640&gt;</code>_)</p>
</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#640](twisted/towncrier#640)
&lt;https://github.com/twisted/towncrier/issues/640&gt;</code><em>,
<code>[#657](twisted/towncrier#657)
&lt;https://github.com/twisted/towncrier/issues/657&gt;</code></em></li>
</ul>
<h1>Towncrier 24.7.1 (2024-07-31)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Bugfixes</h2>
<ul>
<li>When the template file is stored in the same directory with the news
fragments, it is automatically ignored when checking for valid fragment
file names.
(<code>[#632](twisted/towncrier#632)
&lt;https://github.com/twisted/towncrier/issues/632&gt;</code>_)</li>
</ul>
<p>Misc</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/twisted/towncrier/commit/833647e31cde8fd68f0e53063b10e8f3ae4214c3"><code>833647e</code></a>
Update final release.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/f944515bd9b2c46d2cc2fc75bae35f88e4890e0d"><code>f944515</code></a>
Update release docs.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/261c8a23ec5b6a72f39230baf56698fba57bcbc9"><code>261c8a2</code></a>
venv/bin/towncrier build --yes</li>
<li><a
href="https://github.com/twisted/towncrier/commit/89ff29cd85ed7a01868df46746fcb287d9ba5140"><code>89ff29c</code></a>
Update version.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/cb09ddf049e696c25796f8466081a66933577903"><code>cb09ddf</code></a>
Remove a stray &quot;c&quot; in the docs (<a
href="https://redirect.github.com/twisted/towncrier/issues/657">#657</a>)</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4aa8174dc7e843e7b71fc3092216dc2915065135"><code>4aa8174</code></a>
handle empty issue names (<a
href="https://redirect.github.com/twisted/towncrier/issues/656">#656</a>)</li>
<li><a
href="https://github.com/twisted/towncrier/commit/c24e5a1bdcb7b524181d4a84cfa991b8e498e8e4"><code>c24e5a1</code></a>
Update src/towncrier/test/test_check.py</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4d1cd360bc5bfd6722ee5ef079cfbd7f7aa9e512"><code>4d1cd36</code></a>
Merge branch 'trunk' of <a
href="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/dorschw/towncrier">https://github.com/dorschw/towncrier</a>
into trunk</li>
<li><a
href="https://github.com/twisted/towncrier/commit/51129c7042f0a7783cf3a6d9630bbde2fd50216c"><code>51129c7</code></a>
fix comment</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4a94d4a99f9560ee02f027f33ec41325b5bd51ab"><code>4a94d4a</code></a>
Use terminology from tutorial</li>
<li>Additional commits viewable in <a
href="https://github.com/twisted/towncrier/compare/23.11.0...24.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.11.0&new-version=24.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions bot pushed a commit to aio-libs/aiohttp that referenced this pull request Aug 13, 2025
@dependabot
Bump towncrier from 23.11.0 to 24.8.0 (#8888)
9f9b07c 
Bumps [towncrier](https://github.com/twisted/towncrier) from 23.11.0 to
24.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 24.8.0 (2024-08-23)</h2>
<h3>Features</h3>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/643">#643</a>)</li>
<li>Config <!-- raw HTML omitted -->ignore<!-- raw HTML omitted -->
option now supports
wildcard matching via
<a
href="https://docs.python.org/3/library/fnmatch.html#fnmatch.fnmatch">fnmatch</a>.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/644">#644</a>)</li>
<li>Add a config for enforcing issue names using regex.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/649">#649</a>)</li>
</ul>
<h3>Bugfixes</h3>
<ul>
<li>The template file is now ignored based only on the file name.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/638">#638</a>)</li>
<li>Control of the header formatting is once again completely up to the
user when they are writing markdown files (fixes a regression
introduced in
[#610](<a
href="https://redirect.github.com/twisted/towncrier/pull/610">twisted/towncrier#610</a>)).
(<a
href="https://redirect.github.com/twisted/towncrier/issues/651">#651</a>)</li>
<li>Fixed an issue where <!-- raw HTML omitted -->issue_template<!-- raw
HTML omitted -->
failed recognizing the issue name of files with a non-category
suffix (<!-- raw HTML omitted -->.md<!-- raw HTML omitted -->)
(<a
href="https://redirect.github.com/twisted/towncrier/issues/654">#654</a>)</li>
<li>Fixed a bug where orphan news fragments (e.g. +abc1234.feature)
would fail when an <!-- raw HTML omitted -->issue_pattern<!-- raw HTML
omitted --> is
configured. Orphan news fragments are now excempt from <!-- raw HTML
omitted -->issue_pattern<!-- raw HTML omitted --> checks.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/655">#655</a>)</li>
</ul>
<h3>Deprecations and Removals</h3>
<ul>
<li>
<p>Moved towncrier version definition from src/towncrier/_version.py
to pyproject.toml</p>
<p>towncrier.__version__ was removed, after being deprecated in
23.6.0. (<a
href="https://redirect.github.com/twisted/towncrier/issues/640">#640</a>)</p>
</li>
</ul>
<h3>Misc</h3>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/640">#640</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/657">#657</a></li>
</ul>
<h2>Towncrier 24.8.0rc1 (2024-08-19)</h2>
<h3>Features</h3>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>Towncrier 24.8.0 (2024-08-23)</h1>
<p>No changes since the previous release candidate.</p>
<h2>Features</h2>
<ul>
<li>Add <code>.gitkeep</code> as an ignored filename.
(<code>[#643](twisted/towncrier#643)
&lt;https://github.com/twisted/towncrier/issues/643&gt;</code>_)</li>
<li>Config <code>ignore</code> option now supports wildcard matching via
<code>fnmatch
&lt;https://docs.python.org/3/library/fnmatch.html#fnmatch.fnmatch&gt;</code><em>.
(<code>[#644](twisted/towncrier#644)
&lt;https://github.com/twisted/towncrier/issues/644&gt;</code></em>)</li>
<li>Add a config for enforcing issue names using regex.
(<code>[#649](twisted/towncrier#649)
&lt;https://github.com/twisted/towncrier/issues/649&gt;</code>_)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>The template file is now ignored based only on the file name.
(<code>[#638](twisted/towncrier#638)
&lt;https://github.com/twisted/towncrier/issues/638&gt;</code>_)</li>
<li>Control of the header formatting is once again completely up to the
user when they are writing markdown files (fixes a regression introduced
in <a
href="https://redirect.github.com/twisted/towncrier/pull/610">#610</a>).
(<code>[#651](twisted/towncrier#651)
&lt;https://github.com/twisted/towncrier/issues/651&gt;</code>_)</li>
<li>Fixed an issue where <code>issue_template</code> failed recognizing
the issue name of files with a non-category suffix (<code>.md</code>)
(<code>[#654](twisted/towncrier#654)
&lt;https://github.com/twisted/towncrier/issues/654&gt;</code>_)</li>
<li>Fixed a bug where orphan news fragments (e.g. +abc1234.feature)
would fail when an <code>issue_pattern</code> is configured. Orphan news
fragments are now excempt from <code>issue_pattern</code> checks.
(<code>[#655](twisted/towncrier#655)
&lt;https://github.com/twisted/towncrier/issues/655&gt;</code>_)</li>
</ul>
<h2>Deprecations and Removals</h2>
<ul>
<li>
<p>Moved towncrier version definition from src/towncrier/_version.py to
pyproject.toml</p>
<p>towncrier.<strong>version</strong> was removed, after being
deprecated in 23.6.0.
(<code>[#640](twisted/towncrier#640)
&lt;https://github.com/twisted/towncrier/issues/640&gt;</code>_)</p>
</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#640](twisted/towncrier#640)
&lt;https://github.com/twisted/towncrier/issues/640&gt;</code><em>,
<code>[#657](twisted/towncrier#657)
&lt;https://github.com/twisted/towncrier/issues/657&gt;</code></em></li>
</ul>
<h1>Towncrier 24.7.1 (2024-07-31)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Bugfixes</h2>
<ul>
<li>When the template file is stored in the same directory with the news
fragments, it is automatically ignored when checking for valid fragment
file names.
(<code>[#632](twisted/towncrier#632)
&lt;https://github.com/twisted/towncrier/issues/632&gt;</code>_)</li>
</ul>
<p>Misc</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/twisted/towncrier/commit/833647e31cde8fd68f0e53063b10e8f3ae4214c3"><code>833647e</code></a>
Update final release.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/f944515bd9b2c46d2cc2fc75bae35f88e4890e0d"><code>f944515</code></a>
Update release docs.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/261c8a23ec5b6a72f39230baf56698fba57bcbc9"><code>261c8a2</code></a>
venv/bin/towncrier build --yes</li>
<li><a
href="https://github.com/twisted/towncrier/commit/89ff29cd85ed7a01868df46746fcb287d9ba5140"><code>89ff29c</code></a>
Update version.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/cb09ddf049e696c25796f8466081a66933577903"><code>cb09ddf</code></a>
Remove a stray &quot;c&quot; in the docs (<a
href="https://redirect.github.com/twisted/towncrier/issues/657">#657</a>)</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4aa8174dc7e843e7b71fc3092216dc2915065135"><code>4aa8174</code></a>
handle empty issue names (<a
href="https://redirect.github.com/twisted/towncrier/issues/656">#656</a>)</li>
<li><a
href="https://github.com/twisted/towncrier/commit/c24e5a1bdcb7b524181d4a84cfa991b8e498e8e4"><code>c24e5a1</code></a>
Update src/towncrier/test/test_check.py</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4d1cd360bc5bfd6722ee5ef079cfbd7f7aa9e512"><code>4d1cd36</code></a>
Merge branch 'trunk' of <a
href="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/dorschw/towncrier">https://github.com/dorschw/towncrier</a>
into trunk</li>
<li><a
href="https://github.com/twisted/towncrier/commit/51129c7042f0a7783cf3a6d9630bbde2fd50216c"><code>51129c7</code></a>
fix comment</li>
<li><a
href="https://github.com/twisted/towncrier/commit/4a94d4a99f9560ee02f027f33ec41325b5bd51ab"><code>4a94d4a</code></a>
Use terminology from tutorial</li>
<li>Additional commits viewable in <a
href="https://github.com/twisted/towncrier/compare/23.11.0...24.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.11.0&new-version=24.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has
been open for over 30 days.

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigma67 @adiroiban