BREAKING CHANGE: Fix broken support button #12648
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements strong typing for support chat functionality by replacing string literals with a proper SupportDriver enum across frontend and backend components.
- Changed
supportDriverfrom string toSupportDriverenum inpackages/twenty-server/src/engine/core-modules/client-config/client-config.entity.tsenforcing only 'NONE' or 'FRONT' values - Updated frontend components to use
SupportDriver.FRONT/NONEenum values instead of string literals 'front'/'none' in multiple files - Added GraphQL enum type registration for
SupportDriverto ensure proper type checking between frontend and backend - Fixed case mismatch in
useSupportChat.tsthat was preventing support chat from loading
9 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
📊 API Changes ReportGraphQL Schema ChangesGraphQL Schema Changes[log] [log] ✖ Field Support.supportDriver changed type from String! to SupportDriver! GraphQL Metadata Schema ChangesGraphQL Metadata Schema Changes[log] [log] ✖ Field Support.supportDriver changed type from String! to SupportDriver! ✅ Breaking Change ProtocolThis PR title contains "breaking" and breaking changes were detected - the CI will fail as expected. 📝 Action Required: Please add Example: |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:59348 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
changed the title
## Context Support button was missing for configuration having support enabled (FrontApp) <img width="1253" alt="image" src="https://github.com/user-attachments/assets/930e3e0c-05a1-4a5b-820b-bb257f19fdde" /> ## How Recently, we changed some enums from lowercase to uppercase in graphql ## Problem resolution supportDriver was typed as a string where we could have used SupportDriver type. I'm exposing it in the graphql generated files to re-use in the front so this issue cannot happen anymore
Context
Support button was missing for configuration having support enabled (FrontApp)
How
Recently, we changed some enums from lowercase to uppercase in graphql
Problem resolution
supportDriver was typed as a string where we could have used SupportDriver type. I'm exposing it in the graphql generated files to re-use in the front so this issue cannot happen anymore