Fixed sub-field filter dropdown content and icons #12516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced the advanced filters sub-field selection with better UX and cleaner code implementation.
- Refactored
AdvancedFilterSubFieldSelectMenuto use field-specific icons and labels instead of type-based ones - Added immediate field selection in
useSelectFieldUsedInAdvancedFilterDropdownwith smart defaults (e.g., 'amountMicros' for CURRENCY) - Inverted and renamed utility from
isCompositeTypeFilterableByAnySubFieldtoisCompositeTypeNonFilterableByAnySubFieldfor better clarity - Improved performance by moving field selection logic before composite type checks in
AdvancedFilterFieldSelectMenu - Removed redundant
ICON_NAME_BY_ANY_SUB_FIELDconstant map to reduce code complexity
5 files reviewed, 5 comments
Edit PR Review Bot Settings | Greptile
...nt/src/modules/object-record/advanced-filter/components/AdvancedFilterSubFieldSelectMenu.tsx
Show resolved
Hide resolved
...t/src/modules/object-record/record-filter/utils/isCompositeTypeNonFilterableByAnySubField.ts
Show resolved
Hide resolved
...rc/modules/object-record/advanced-filter/hooks/useSelectFieldUsedInAdvancedFilterDropdown.ts
Show resolved
Hide resolved
...front/src/modules/object-record/advanced-filter/components/AdvancedFilterFieldSelectMenu.tsx
Show resolved
Hide resolved
...rc/modules/object-record/advanced-filter/hooks/useSelectFieldUsedInAdvancedFilterDropdown.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:39870 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 10, 2025
This PR improves the sub-field selection UX in advanced filters. - Now using the icon of the field instead of the field type - Now using the label of the field instead of the field type - Removed now useless constant ICON_NAME_BY_ANY_SUB_FIELD - Now selects a default value (any or default sub-field for type) when clicking on the field, instead of waiting for the user to select the sub-field Fixes twentyhq/core-team-issues#1005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the sub-field selection UX in advanced filters.
Fixes twentyhq/core-team-issues#1005