modal fix #12514
Merged
modal fix #12514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed unexpected modal closure by implementing a global click-outside prevention mechanism using React props.
- Added
dataGloballyPreventClickOutsideprop topackages/twenty-front/src/modules/ui/layout/modal/components/Modal.tsxto control click-outside behavior - Modernized attribute naming from kebab-case to camelCase in
packages/twenty-front/src/modules/ui/layout/modal/components/ConfirmationModal.tsxfollowing React conventions - Ensures modals remain open during critical workflows like item restoration
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:37160 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 10, 2025
issue was the modal was closing itself due to onclickoutside while it should have been excluded fixes twentyhq#12512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue was the modal was closing itself due to onclickoutside while it should have been excluded
fixes #12512