Fix missing New Note / New Task button #12513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed incorrect permission logic that prevented 'New Note' and 'New Task' buttons from displaying in the UI.
- Changed condition in
packages/twenty-front/src/modules/activities/notes/components/Notes.tsxfrom!hasObjectUpdatePermissionstohasObjectUpdatePermissionsto correctly show the 'New Note' button - Applied similar fix in
packages/twenty-front/src/modules/activities/tasks/components/TaskGroups.tsxfor the 'New Task' button visibility - Reorganized imports in TaskGroups.tsx for better code organization
- Note: Visibility logic between empty/non-empty states may need review for consistency
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:26762 This environment will automatically shut down when the PR is closed or after 5 hours. |
FelixMalfait
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Note button was missing because of the wrong condition being applied to display it
