Upgrade to Node22 #12488
Merged
Upgrade to Node22 #12488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major upgrade to Node.js v22.12.0 across all packages to support ESM modules, particularly for BlocknoteJS compatibility, with changes to default serverless function runtime and dependency restructuring.
- Upgraded base Node.js version from 18.17.1 to 22.12.0 in all Dockerfiles, package.json files, and GitHub Actions
- Added new migration
1749205425841-UpdateServerlessFunctionDefaultRuntimeToNode22.tsto set Node 22.x as default runtime - Removed version 0.43 database migrations as they're no longer needed
- Modified BlocknoteJS import in
record-input-transformer.service.tsto use dynamic imports for ESM/CJS compatibility - Added new feature flag
IS_AI_ENABLEDin feature-flags.ts, leveraging Node 22's improved capabilities
27 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
8
to
10
| PageDecorator, | ||
| PageDecoratorArgs, | ||
| } from '~/testing/decorators/PageDecorator'; |
There was a problem hiding this comment.
style: Indentation uses 4 spaces while rest of file uses 2 spaces
Suggested change
| PageDecorator, | |
| PageDecoratorArgs, | |
| } from '~/testing/decorators/PageDecorator'; | |
| PageDecorator, | |
| PageDecoratorArgs, | |
| } from '~/testing/decorators/PageDecorator'; |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:14639 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 10, 2025
BlocknoteJS requires an ESM module where our server is CJS, this forced us to pin the server-util version, which led us to force the resolution of several packages, leading to bugs downstream. From Node 22.12 Node supports requiring ESM modules (available from Node 22.0 with a flag). So I upgrade the module. I picked Node 22 and not Node 23 or Node 24 because 22 is the LTS and we don't plan to change node versions frequently. If you remain on Node 18, things should still mostly work, except if you edit a Rich Text field. I also starting changing the default runtime for Serverless Functions which isn't directly related. This means new serverless functions will be created on Node 22, but we will still need another PR to migrate existing serverless functions before September (end of support by AWS). (In this PR I also remove the upgrade commands from 0.43 since they rely on Blocknote and I didn't want to have to deal with this) --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlocknoteJS requires an ESM module where our server is CJS, this forced us to pin the server-util version, which led us to force the resolution of several packages, leading to bugs downstream.
From Node 22.12 Node supports requiring ESM modules (available from Node 22.0 with a flag). So I upgrade the module.
I picked Node 22 and not Node 23 or Node 24 because 22 is the LTS and we don't plan to change node versions frequently.
If you remain on Node 18, things should still mostly work, except if you edit a Rich Text field.
I also starting changing the default runtime for Serverless Functions which isn't directly related. This means new serverless functions will be created on Node 22, but we will still need another PR to migrate existing serverless functions before September (end of support by AWS).
(In this PR I also remove the upgrade commands from 0.43 since they rely on Blocknote and I didn't want to have to deal with this)