Add filters to search record action #12481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements filtering capabilities for the Search Records workflow action with advanced filter UI and state management across front and backend.
- Added new
AdvancedFilterValueFormInputandAdvancedFilterValueFormCompositeFieldInputcomponents to handle specialized form inputs like ADDRESS and CURRENCY fields in filters - Integrated new
AdvancedFilterContextfor centralized filter updates, with proper hooks integration inuseRemoveRecordFilter,useUpsertRecordFilter, and related hooks - Extended workflow schema and backend types to support complex filter structures including
recordFilterGroups,recordFilters, andgqlOperationFilter - Created
WorkflowFindRecordFiltersandWorkflowFindRecordFiltersEffectcomponents to manage nested filter groups and filter initialization in workflows - Modified
FindRecordsWorkflowActionbackend class to handle the new filter structure throughgqlOperationFilterproperty
20 file(s) reviewed, 17 comment(s)
Edit PR Review Bot Settings | Greptile
...src/modules/object-record/advanced-filter/components/AdvancedFilterRootRecordFilterGroup.tsx
Show resolved
Hide resolved
...-front/src/modules/object-record/advanced-filter/components/AdvancedFilterValueFormInput.tsx
Show resolved
Hide resolved
...-front/src/modules/object-record/advanced-filter/components/AdvancedFilterValueFormInput.tsx
Show resolved
Hide resolved
...ules/object-record/advanced-filter/components/AdvancedFilterValueFormCompositeFieldInput.tsx
Show resolved
Hide resolved
...enty-front/src/modules/object-record/advanced-filter/states/context/AdvancedFilterContext.ts
Show resolved
Hide resolved
...ules/workflow/workflow-steps/workflow-actions/components/WorkflowFindRecordFiltersEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/hooks/useCheckCustomDomainValidRecords.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/hooks/useCheckCustomDomainValidRecords.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/workspace/hooks/useCheckCustomDomainValidRecords.ts
Outdated
Show resolved
Hide resolved
...ules/workflow/workflow-executor/workflow-actions/record-crud/find-records.workflow-action.ts
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-filters-in-search-record-action
branch
from
d1f0df6 to
b7db9b8
Compare
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:25850 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
force-pushed
the
tt-filters-in-search-record-action
branch
from
b7db9b8 to
087de62
Compare
thomtrp
commented
Jun 6, 2025
| label: 'Search Records', | ||
| type: 'FIND_RECORDS', | ||
| icon: 'IconSearch', | ||
| }, |
There was a problem hiding this comment.
will hide this again once reviews are done
martmull
reviewed
Jun 6, 2025
|
|
||
| const filterType = recordFilter.type; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
looks like it does not work well tbh, i personally prefer the regular way to display composite fields (see general comment)
There was a problem hiding this comment.
yep design is not done for now. design should match regular way but in column. Will be for another PR
martmull
approved these changes
Jun 6, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 10, 2025
First PR to add filters to send records. Lot of work left, but I want to split. I mainly want to validate the architecture there. https://github.com/user-attachments/assets/63375a75-ba88-49df-8c12-5e3e58de5342 TODO in next PRs: - fix design - make filters reliable. Some composite fields are not implemented and some fields like datetime do not work well - improve typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to add filters to send records. Lot of work left, but I want to split. I mainly want to validate the architecture there.
Enregistrement.de.l.ecran.2025-06-06.a.11.09.08.mov
TODO in next PRs: