Fix ClientConfigProviderEffect infite loop #12472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed an infinite loop in the client configuration fetching mechanism that occurred when API errors were encountered. The isLoadedOnce flag wasn't being set on errors, causing continuous refetch attempts.
- Added
isLoadedOnce: truein error state updates inuseClientConfig.tsto properly terminate fetch cycles - Issue occurred in dependency array tracking of
clientConfigApiStatus.isLoadedOnceandisLoadingstates - Previous implementation caused effect to re-trigger fetches indefinitely on API errors
- Fix aligns with Recoil state management guidelines by ensuring proper state updates in error scenarios
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:2877 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 5, 2025
charlesBochet
pushed a commit
that referenced
this pull request
Jun 6, 2025
Fixes an infinite loop introduced by #12371 An infinite loop was triggered when there was an error when fetching the client config. Cause of the bug: `isLoadedOnce` wasn't set to true when catching an error in `useClientConfig`. This effect then created an infinite loop inside `ClientConfigProviderEffect` because `fetchClientConfig` updated `clientConfigApiStatus.isLoading` but not `isLoadedOnce`. ```typescript useEffect(() => { if ( !clientConfigApiStatus.isLoadedOnce && !clientConfigApiStatus.isLoading ) { fetchClientConfig(); } }, [ clientConfigApiStatus.isLoadedOnce, clientConfigApiStatus.isLoading, fetchClientConfig, ]); ```
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 10, 2025
Fixes an infinite loop introduced by twentyhq#12371 An infinite loop was triggered when there was an error when fetching the client config. Cause of the bug: `isLoadedOnce` wasn't set to true when catching an error in `useClientConfig`. This effect then created an infinite loop inside `ClientConfigProviderEffect` because `fetchClientConfig` updated `clientConfigApiStatus.isLoading` but not `isLoadedOnce`. ```typescript useEffect(() => { if ( !clientConfigApiStatus.isLoadedOnce && !clientConfigApiStatus.isLoading ) { fetchClientConfig(); } }, [ clientConfigApiStatus.isLoadedOnce, clientConfigApiStatus.isLoading, fetchClientConfig, ]); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an infinite loop introduced by #12371
An infinite loop was triggered when there was an error when fetching the client config.
Cause of the bug:
isLoadedOncewasn't set to true when catching an error inuseClientConfig.This effect then created an infinite loop inside
ClientConfigProviderEffectbecausefetchClientConfigupdatedclientConfigApiStatus.isLoadingbut notisLoadedOnce.