Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 5, 2025

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Large-scale internationalization update adding 'Forbidden' message translations across multiple language files and cleaning up duplicate entries.

  • Added new translation key '7JBW66' for 'Forbidden' error message across 20+ locale files in packages/twenty-front/src/locales/
  • Removed duplicate file path references to PageAddButton.tsx from 'New record' translations while maintaining DefaultRecordActionsConfig.tsx reference
  • Many new translations are currently empty (msgstr) and need actual translations before deployment
  • Generated TypeScript files (.ts) updated to include new 'Forbidden' key in appropriate message structures
  • Automated update via GitHub action indicates systematic i18n workflow integration

21 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 2307 to +2311
msgid "First Name"
msgstr "Nom"

#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Forbidden' string. This needs to be translated to Catalan to maintain full i18n coverage.

Suggested change
msgid "First Name"
msgstr "Nom"
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "First Name"
msgstr "Nom"
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "Forbidden"
msgstr "Prohibit"

Comment on lines 2307 to +2311
msgid "First Name"
msgstr "الاسم الأول"

#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider providing Arabic translation for new 'Forbidden' string rather than leaving it empty

Comment on lines 2307 to +2311
msgid "First Name"
msgstr "Vorname"

#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Translation missing for new 'Forbidden' string. Add German translation to maintain consistency.

Suggested change
msgid "First Name"
msgstr "Vorname"
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "Forbidden"
msgstr "Verboten"

Comment on lines 2307 to +2314
msgid "First Name"
msgstr "Prénom"

#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "Forbidden"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for new 'Forbidden' string - needs French translation

Suggested change
msgid "First Name"
msgstr "Prénom"
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "Forbidden"
msgstr ""
#. js-lingui-id: 7JBW66
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
msgid "Forbidden"
msgstr "Interdit"

@FelixMalfait FelixMalfait merged commit 39d3c6a into main Jun 5, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 5, 2025 14:01
Copy link
Contributor Author

github-actions bot commented Jun 5, 2025

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5595:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5566:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5575:7)�[39m
danger-results://tmp/danger-results-fdb7f7cb.json

Generated by 🚫 dangerJS against f513cf4

charlesBochet pushed a commit that referenced this pull request Jun 6, 2025
Created by Github action

---------

Co-authored-by: github-actions <[email protected]>
abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 10, 2025
Created by Github action

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant