Skip to content

Fix: Popover with hover and click triggers closes on mouseleave #41511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025
Merged

Fix: Popover with hover and click triggers closes on mouseleave #41511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95ddec7
Fix: Popover with hover and click triggers closes on mouseleave
google-labs-jules[bot] Jun 1, 2025
57cf47d
Merge branch 'main' into fix-popover-click-hover-trigger
julien-deramond Jun 2, 2025
15399f4
Removed `test-popover.html`
julien-deramond Jun 2, 2025
ee34fa6
Fix linting issues
julien-deramond Jun 2, 2025
ec5cf1d
Add unit test
julien-deramond Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions js/src/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ class Tooltip extends BaseComponent {
if (trigger === 'click') {
EventHandler.on(this._element, this.constructor.eventName(EVENT_CLICK), this._config.selector, event => {
const context = this._initializeOnDelegatedTarget(event)
if (context._isShown() && context._activeTrigger[TRIGGER_CLICK]) {
context._activeTrigger[TRIGGER_CLICK] = false
} else {
context._activeTrigger[TRIGGER_CLICK] = true
}
context.toggle()
})
} else if (trigger !== TRIGGER_MANUAL) {
Expand Down
Loading
Loading