Replace the deprecated color-adjust with print-color-adjust

[AdrianCurtin]

https://developer.mozilla.org/en-US/docs/Web/CSS/print-color-adjust

This fixes issues with autoprefixer ^10.4.6
(https://github.com/postcss/autoprefixer/releases/tag/10.4.6)
Which throw warnings for use of color-adjust CSS

Fixes #36259

[mdo]

There's no need to update the dist files, that happens on release. Can you revert those changes?

[AdrianCurtin]

@mdo done

[mbrodala]

By now this is a duplicate of #36258 so it can be closed IMO.

(Not sure if a PR for 4.x is necessary or if a backport is possible though.)

[mdo]

By now this is a duplicate of #36258 so it can be closed IMO.

(Not sure if a PR for 4.x is necessary or if a backport is possible though.)

They're separate, so we'll leave both PRs.

[XhmikosR]

@mdo: I'm not sure we can apply this in v4 due to our supported browsers.

[AdrianCurtin]

@XhmikosR
If this is the case and you want to leave it in, you should use an older version of autoprefixer, otherwise the warning will be treated as an error in production

Also prevents automated deployments without finding workarounds to modify the installed version of autoprefixer

[XhmikosR]

It's not an error, it's a warning. And we can't control the tools the consumers of the package use.

[AdrianCurtin]

@XhmikosR , I guess that its not specifically an error, but because its somewhat common to enable "treat warnings as errors" it does affect a lot of automatic deployments. It's true that you can't control what tools other users use, but you can control which tools that you use. So if you want to update the prefixer in v5, but not in v4, that's another way to get around these warnings.

https://caniuse.com/?search=print-color-adjust

Currently the only web browsers which really used only color-adjust appear to have been earlier builds of firefox for which 48-97, during which print-color-adjust enjoyed partial support. Other browsers do not support color-adjust or require the webkit prefix.

So maintaining this to support old versions of firefox eschews support of that functionality in Edge, Chrome, Safari etc

[jrochkind]

It's not an error, it's a warning. And we can't control the tools the consumers of the package use.

I am using bootstrap 4 via the ruby gem, which used to be a supported/recommended path to using bootstrap 4. The bootstrap 4 ruby gem has a dependency on autoprefixer-rails. So autoprefixer is not a tool I chose to use, it's in fact one bootstrap did control.

While my current setup doesn't cause any builds to fail, I now get this autoprefixer warning in all my build output -- written directly to stdout, in the middle of my build output. Which is a bit annoying.

I don't think I have a way to remove autoprefixer from my app, as it's a bootstrap dependency; I guess I could lock to an older version that doesn't produce this warning. And hope i don't lose anything else from future autoprefixers that I might need.

If anyone has any other ideas for eliminating this warning from my use of bootstrap 4 via ruby gem, I'd be interested in hearing them. I wish I had a way to configure autoprefixer to not output this warning, but I don't believe I do.

[kvnloughead]

I have the same issue as @jrochkind and would be glad for a way to suppress this warning

[rodrigo-arias]

@XhmikosR thanks for merging this fix, any plans to release a patch version for Bootstrap 4?

[XhmikosR]

Yeah, we will release a new version soon, maybe this week.

…

On Wed, Jun 8, 2022, 19:19 Rodrigo Arias ***@***.***> wrote: @XhmikosR <https://github.com/XhmikosR> thanks for merging this fix, any plans to release a patch version for Bootstrap 4? — Reply to this email directly, view it on GitHub <#36283 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNJFLYM7HOJGNSPZ5ZDVODBYRANCNFSM5VF7CGRA> . You are receiving this because you were mentioned.Message ID: ***@***.***>