Skip to content

Conversation

@k-utsumi
Copy link
Contributor

@k-utsumi k-utsumi commented Apr 9, 2021

I set it as below, but no negative margin was added.
$spacers: (0\.5: ($spacer * .125));

After investigating, it seems that 0 \ .5 is also evaluated as 0.
So I changed it to string comparison.

HTML example: <img class="mt-n0.5">

I set it as below, but no negative margin was added.
`$spacers: (0\.5: ($spacer * .125));`

After investigating, it seems that `0 \ .5` is also evaluated as 0.
So I changed it to string comparison.

HTML example: `<img class="mt-n0.5">`
@k-utsumi k-utsumi requested a review from a team as a code owner April 9, 2021 08:50
@mdo mdo added the css label Apr 9, 2021
@mdo
Copy link
Member

mdo commented Apr 9, 2021

Is this needed in main for v5 as well?

@k-utsumi
Copy link
Contributor Author

k-utsumi commented Apr 11, 2021

@mdo mdo added the v4 label Apr 14, 2021
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Any objections @twbs/css-review?

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, never thought about such values 👌

@XhmikosR XhmikosR merged commit 086c0bf into twbs:v4-dev Jun 24, 2021
@k-utsumi k-utsumi deleted the patch-1 branch June 24, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants