Skip to content

Update to Jekyll 1.5.0 #13178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2014
Merged

Update to Jekyll 1.5.0 #13178

merged 1 commit into from
Mar 25, 2014

Conversation

XhmikosR
Copy link
Member

It has the 1.4.3 WIndows bug fixed plus it seems it's no longer needed to run @chcp 65001 anymore before calling jekyll.

/CC @cvrebert @mdo @juthilo

The 1.4.3 Windows bug is fixed, plus the encoding workaround isn't needed anymore.
@cvrebert
Copy link
Collaborator

👍

@juthilo
Copy link
Collaborator

juthilo commented Mar 25, 2014

I haven't had a chance to test the new version yet, but I trust your judgement, so :shipit: :) Thanks again for looking into this, @XhmikosR !

@XhmikosR
Copy link
Member Author

I'd still like someone else to verify that the chcp 65001 hack isn't needed anymore.

See also https://github.com/juthilo/run-jekyll-on-windows/issues/6

XhmikosR added a commit that referenced this pull request Mar 25, 2014
@XhmikosR XhmikosR merged commit ba1790b into master Mar 25, 2014
@XhmikosR XhmikosR deleted the jekyll-1.5.0 branch March 25, 2014 17:26
@juthilo
Copy link
Collaborator

juthilo commented Mar 26, 2014

Hmm, seems to me we still need to set the encoding in _config.yml (which is equivalent to chcp 65001).

I updated and replaced jekyll to/with v1.5.0 locally and when I removed encoding: UTF-8 from the config, I got the usual Liquid exception.

@juthilo
Copy link
Collaborator

juthilo commented Mar 26, 2014

However, as Bootstrap users don't need to manually run any command (due to the encoding config), my suggestion would be to leave everything as is. I'll update my run-jekyll-on-windows guide, which we link to in the README and which is more suited for this kind of general information (the chcp part) IMO. Thoughts @mdo @cvrebert @XhmikosR ?

@XhmikosR
Copy link
Member Author

Yeah but that isn't the case with 1.4.3 where we had to do the chcp workaround even though encoding was set in configuration.

So at least now it respects that. IIRC version 2 has this completely fixed.

@XhmikosR
Copy link
Member Author

I removed that info from our Readme because for Bootstrap there's no need for it. You can add it in your guide of course.

From my tests I have yet to find a project that raises that exception with 1.5.0 apart from Bootstrap.
I'll dig into this more tomorrow but for bootstrap I don't think we need to add more apart from 1.5.0 being required.

@XhmikosR
Copy link
Member Author

I confirmed what I said above, even for Ratchet, which does not have encoding set in _config.yml, 1.5.0 works fine without the chcp hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants