This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Warn about usage of redundant column classes #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Travis error is due to us having this mistake in one place in the BS docs 😆 ) |
|
@cvrebert: looking good! Tested this on a real project and seems to work fine. I didn't go through all the code but it looks good. |
|
BTW, I guess the same applied to |
|
I don't think so? IIRC, hidden/visible only apply at one specific screen size tier, unlike the other grid stuff; which is unfortunate and inconsistent. |
|
Hmm, I thought the same applied to the hidden classes. |
|
Wow, looks good to me! |
|
X-Ref for the Travis failure: twbs/bootstrap#14684 |
cvrebert
added a commit
that referenced
this pull request
Sep 25, 2014
Warn about usage of redundant column classes
hnrch02
added a commit
that referenced
this pull request
Sep 25, 2014
hnrch02
added a commit
that referenced
this pull request
Sep 25, 2014
hnrch02
added a commit
that referenced
this pull request
Sep 25, 2014
hnrch02
added a commit
that referenced
this pull request
Sep 25, 2014
hnrch02
added a commit
that referenced
this pull request
Sep 25, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.