This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Implement simple lint-via-POSTing-HTML HTTP API #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, LGTM. |
|
Merging this for now. |
cvrebert
added a commit
that referenced
this pull request
Oct 21, 2014
Implement simple lint-via-POSTing-HTML HTTP API
|
I don't really have any comments on the technical side. I'm only wondering if the dependencies overhead is really worth this feature at this point. Other than that, it looks good :) |
|
Express isn't that big, around ~1500 SLOC so I don't think the overhead is too big in this case. |
|
@cvrebert: should |
|
The Dockerfile shouldn't. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134.
Also, add a Dockerfile for deployment.
CC: @hnrch02 @XhmikosR