Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Conversation

cvrebert
Copy link
Collaborator

Fixes #69, except I haven't implemented a CLI option for this yet, since it'll require actually parsing command-line arguments, and I don't know what Node.js library to use for that.

@cvrebert cvrebert added this to the v0.3.0 milestone Sep 26, 2014
@cvrebert cvrebert force-pushed the disabling branch 2 times, most recently from daa29ed to a03fddf Compare September 26, 2014 18:39
@cvrebert
Copy link
Collaborator Author

CC: @hnrch02 @XhmikosR for review

@zacechola
Copy link
Collaborator

and I don't know what Node.js library to use for that.

I've had good luck with minimist.

https://www.npmjs.org/package/minimist

Edit: and for something built on top of minimist with more options (and also has substack's blessing): https://github.com/chevex/yargs

@XhmikosR
Copy link
Member

@cvrebert: I don't want to halt the PR, so if @hnrch02 says it's OK, just go ahead. :) Not sure when I'll be able to test this out.

@hnrch02
Copy link
Collaborator

hnrch02 commented Sep 26, 2014

I've used https://github.com/visionmedia/commander.js before and I prefer it over minimist. commander is more opinionated than minimist and also provides automated --help output.

@XhmikosR
Copy link
Member

I wonder, will we still need glob if we use commander?

On Fri, Sep 26, 2014 at 10:32 PM, Heinrich Fenkart <[email protected]

wrote:

I've used https://github.com/visionmedia/commander.js before and I prefer
it over minimist. commander is more opinionated than minimist and also
provides automated --help output.


Reply to this email directly or view it on GitHub
#103 (comment).

@hnrch02
Copy link
Collaborator

hnrch02 commented Sep 26, 2014

AFAIK it doesn't do globbing, so yes, I suppose so.

@cvrebert
Copy link
Collaborator Author

Think I'll punt the CLI part to another issue/PR.
Does this PR as-is look good?

@hnrch02
Copy link
Collaborator

hnrch02 commented Sep 26, 2014

:shipit:

cvrebert added a commit that referenced this pull request Sep 26, 2014
Add ability to disable certain lint checks
@cvrebert cvrebert merged commit bfc8e2b into master Sep 26, 2014
@cvrebert cvrebert deleted the disabling branch September 26, 2014 19:59
This was referenced Sep 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable certain specified lint checks
4 participants