Hide time pickers when "All Day" toggle is enabled in event editor #9818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating or editing calendar events with "All Day" enabled, the time input fields (From/To) were still visible showing "00:00", which is confusing since time is irrelevant for all-day events. Changes: - Conditionally render TimePicker components only when isAllDay is false - Time pickers now completely hidden for all-day events - Only date pickers remain visible for all-day events Fixes tutao#9817
|
We have to check with our PO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a UX issue where the event editor shows "00:00" time input fields even when the "All Day" toggle is enabled.
Fixes #9817
Changes
File:
src/calendar-app/calendar/gui/eventeditor-view/EventTimeEditor.ts!attrs.editModel.isAllDayImpact
Before: All-day events show disabled time fields with "00:00"
After: All-day events show only date fields, time fields are hidden
Testing
Notes